Project

General

Profile

Actions

Bug #17066

open

Relative URLs in ipsec-profile-wizard menu entries

Bug #17066: Relative URLs in ipsec-profile-wizard menu entries

Added by Matthew Fearnley about 19 hours ago. Updated about 3 hours ago.

Status:
Confirmed
Priority:
Low
Assignee:
-
Category:
IPsec Profile Wizard
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Affected Version:
Affected Plus Version:
26.07
Affected Architecture:
All

Description

The menu entries configured for pfSense-pkg-ipsec-profile-wizard don't start with slashes:

        <menu>
            <name>IPsec Export: Apple Profile</name>
            <tooltiptext>IPsec Profile Export</tooltiptext>
            <section>VPN</section>
            <url>vpn_ipsec_profile.php</url>
        </menu>
        <menu>
            <name>IPsec Export: Windows</name>
            <tooltiptext>IPsec Profile Export</tooltiptext>
            <section>VPN</section>
            <url>vpn_ipsec_export_win.php</url>
        </menu>

This means they point to the wrong place in the (uncommon but valid) case that the current URL is not in the root, e.g. /packages/cron/cron.php

The easy fix is obviously to prepend a '/' to the menu entries.

Although there's also potentially a case to be made for head.inc automatically absolutizing all menu URLs, if there's no case where relative URLs could be useful.

Updated by Matthew Fearnley about 19 hours ago Actions #1

Sorry, duplicate of #17065.

Updated by Kris Phillips about 3 hours ago Actions #2

  • Status changed from New to Confirmed
  • Priority changed from Normal to Low

I can confirm that this is true for <menu> entries for this package. It does not appear to affect functionality, however, so I'm marking this as a priority of "Low".

Marking Confirmed.

Actions

Also available in: Atom