Bug #25
closed
Shaper Wizard, Penalty Box screen, Address field Alias Usage
100%
Description
On the Penalty Box screen of the Traffic Shaper Wizard, the Address field indicates that an Alias may be used ("NOTE: You can also use a Firewall Alias in this location.") but the field does not have a red background or autocomplete alias names.
Changing line 289 in usr/local/www/wizards/traffic_shaper_wizard.xml to "inputalias" does give the red background, but still doesn't have autocomplete. (Neither does the similar option on the VoIP screen, so that may be a different bug)
Files
Updated by Ermal Luçi over 15 years ago
- Status changed from New to Needs Patch
There is no javascript that i can see to help even if the autocomplete is enabled.
So i think this can be lived with for now and be fixed on 2.0.
Updated by Jim Pingle over 15 years ago
- File penaltyboxalias.patch penaltyboxalias.patch added
- Status changed from Needs Patch to New
That's about what I expected. Thanks for having a look at it.
I've attached a patch for 1.2.3-RC that will at least change the field to have a red background as the previous screen does.
Even without the Javascript, it feels like it should at least be consistent (Either both red or both normal) instead of two different ways.
Updated by Scott Ullrich about 15 years ago
Partially resolved. Both versions now show a red input alias box but the javascript appears to not be hooked in.
Updated by Scott Ullrich about 15 years ago
- % Done changed from 0 to 100
Applied in changeset 44c10295114daaf8d65a0502f01f1d27131f1623.