Actions
Bug #2685
closed
Unnecessary fields in firewall aliases edit page
Status:
Needs Patch
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
11/18/2012
Due date:
% Done:
0%
Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.1
Affected Architecture:
Description
On the "Firewall: Aliases: Edit" page additional input fields are shown / enabled although they are unused / misleading.
- The Host(s) alias does not require the CIDR field.
- The Port(s) alias does not require the CIDR field.
- The URL alias does not require the CIDR and description (not used in the code) fields.
- The URL table alias does not require description (not used in the code) field.
Also for the URL table alias the CIDR field is used to determine the update frequency and is in days which could be made clearer, as it currently ranges from 1-128 (due to CIDR) with a default value of 128 instead of the targeted 7 days (empty CIDR field, which cannot be selected currently).
Additionally there are various '$dont_update = true;' scattered through the code that are never used.
Updated by Chris Buechler over 11 years ago
- Status changed from New to Needs Patch
the fields that aren't relevant are disabled. No actual bugs here. if you want to submit a merge request to improve things, feel free.
Actions