Project

General

Profile

Bug #3001

Captive portal Voucher sync on HTTPS with custom port

Added by Zoltan Lukacs about 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Ermal Luçi
Category:
Captive Portal
Target version:
Start date:
05/21/2013
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.0.x
Affected Architecture:
All

Description

Voucher sync between 2 pfSense instances using webGUI HTTPS with custom port (Ex. 33333) is not working.

An error code was received while attempting CaptivePortalVoucherSync XMLRPC sync with http://192.168.67.16:33333 - Code 2: Invalid return payload: enable debugging to examine incoming payload

On the below code snippet you can see that HTTPS will be used only when port == 443.

https://github.com/pfsense/pfsense/blob/master/usr/local/www/services_captiveportal_vouchers.php

if($newvoucher['vouchersyncport'] == "443") 
    $url = "https://{$newvoucher['vouchersyncdbip']}";
else 
    $url = "http://{$newvoucher['vouchersyncdbip']}";

I would like to fix this, but I'm not a PHP coder... :(
Suggestion: Ability to select protocol on webGUI beside custom port.

Associated revisions

Revision f9d480ff (diff)
Added by Ermal Luçi about 6 years ago

Fixes #3001, Check the protocol of the webgui to determine if https is being used for custom ports.

Revision 368d34c3 (diff)
Added by Ermal Luçi about 6 years ago

Fixes #3001, Check the protocol of the webgui to determine if https is being used for custom ports.

History

#1 Updated by Ermal Luçi about 6 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#2 Updated by Ermal Luçi about 6 years ago

#3 Updated by Josh Cavalier almost 6 years ago

Ok, I have tested this and it works properly. I've setup two VM's with three interfaces each. WAN (192.168.17.0/24), LAN (host only network (10.10.10.0/24)) and OPT1 (host only interface). I then changed the HTTPS port to 33333 on both machines (as above example) and configured captive portal on host 1 - OPT1. I also created vouchers on host1 (screenshot). I then configured captive portal on host2 - OPT1, enabled vouchers and entered host1's LAN details in the Voucher database synchronization including port 33333. Running a packet capture on host1 shows the SSL stream over port 33333, and the screenshot shows vouchers synced properly. I have tested this twice.

#4 Updated by Josh Cavalier almost 6 years ago

Captive portal log also shows successful sync.

#5 Updated by Renato Botelho almost 6 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF