Project

General

Profile

Bug #303

On input errors, system_gateways_edit.php doesn't retain interface

Added by Chris Buechler over 9 years ago. Updated over 9 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Gateways
Target version:
Start date:
01/16/2010
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.0
Affected Architecture:

Description

When entering anything on system_gateways_edit.php that triggers an input error, the interface isn't retained on the page showing the input errors, it always resets to WAN while keeping all the other correct values.

Associated revisions

Revision 889cb324 (diff)
Added by Ermal Luçi over 9 years ago

Ticket #303. The friendly interface is saved on the config and not the real one.

Revision 9c10b00f (diff)
Added by Ermal Luçi over 9 years ago

Ticket #303. Use the config item when editing gateways so all fields are correctly processed.

Revision e90db2b4 (diff)
Added by Ermal Luçi over 9 years ago

Revert "Ticket #303. Use the config item when editing gateways so all fields are correctly processed."

This reverts commit 9c10b00f3eb22f45e2fb704ca9f1786942d69ad8.

Revision 6a94050a (diff)
Added by Ermal Luçi over 9 years ago

Revert "Ticket #303. The friendly interface is saved on the config and not the real one."

This reverts commit 889cb3241aa6bd192c42147316faf503c559fce2.

Revision 883c53c9 (diff)
Added by Ermal Luçi over 9 years ago

Ticket #303. Fix very many bugs in this code. From strings that were not quoted propperly to completely broken code paths.

Revision d52b71c7 (diff)
Added by Ermal Luçi over 9 years ago

Ticket #303. Fix gateway address checking.

Revision 5313aea5 (diff)
Added by Ermal Luçi over 9 years ago

Ticket #303. Correctly retain the interface in case or validation errors.

History

#1 Updated by Ermal Luçi over 9 years ago

  • Status changed from New to Feedback

Patched.

#2 Updated by Chris Buechler over 9 years ago

  • Status changed from Feedback to New

No change (looks like all the related changes were reverted).

#3 Updated by Ermal Luçi over 9 years ago

  • Status changed from New to Feedback

Now should be a lot better.

#4 Updated by Chris Buechler over 9 years ago

  • Status changed from Feedback to New

The particular issue noted in this ticket is still a problem. To replicate:
Add a gateway on LAN on system_gateways_edit.php
Choose an IP that isn't on the LAN subnet, to trigger the input error.
Click Save.
Note the interface has changed from LAN to WAN, though the other input is retained. This creates user error, as users forget to set the interface back.

#5 Updated by Ermal Luçi over 9 years ago

  • Status changed from New to Feedback

#6 Updated by Chris Buechler over 9 years ago

  • Status changed from Feedback to Resolved

fixed

Also available in: Atom PDF