Project

General

Profile

Actions
Copy link

Bug #348

closed

firewall_aliases_import

Added by Perry Mason about 14 years ago. Updated about 14 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
-
Target version:
-
Start date:
02/09/2010
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:

Description

1. Correct how data is stored in config.xml
2. Correct type to host
3. Add details
4. Add option to import CIDR networks
How it looks when edit in webgui http://tinyurl.com/yjrenkh
How it looks in config.xml

    <aliases>
        <alias>
            <address>123.123.123.123 231.231.231.231
 111.111.111.111
 222.222.222.222</address>
            <name>test1</name>
            <type>network</type>
            <descr>test1</descr>
        </alias>
        <alias>
            <address>1.1.1.1
 2.2.2.2
 3.3.3.3
 4.4.4.4</address>
            <name>test2</name>
            <type>network</type>
            <descr>test2</descr>
        </alias>
    </aliases>
New version
    <aliases>
        <alias>
            <name>test1</name>
            <address>123.123.123.123 231.231.231.231 111.111.111.111 222.222.222.222</address>
            <type>host</type>
            <descr>test1</descr>
            <detail>Entry added Tue, 09 Feb 2010 10:01:21 +0100||Entry added Tue, 09 Feb 2010 10:01:21 +0100||Entry added Tue, 09 Feb 2010 10:01:21 +0100||Entry added Tue, 09 Feb 2010 10:01:21 +0100||</detail>
        </alias>
        <alias>
            <name>test2</name>
            <address>1.1.1.1 2.2.2.2 3.3.3.3 4.4.4.4</address>
            <type>host</type>
            <descr>test2</descr>
            <detail>Entry added Tue, 09 Feb 2010 10:02:16 +0100||Entry added Tue, 09 Feb 2010 10:02:16 +0100||Entry added Tue, 09 Feb 2010 10:02:16 +0100||Entry added Tue, 09 Feb 2010 10:02:16 +0100||</detail>
        </alias>
        <alias>
            <name>test3</name>
            <address>58.147.128.0/19 110.34.40.0/21 111.125.152.0/21 117.55.192.0/20</address>
            <type>network</type>
            <descr>test3</descr>
            <detail>Entry added Tue, 09 Feb 2010 10:04:40 +0100||Entry added Tue, 09 Feb 2010 10:04:40 +0100||Entry added Tue, 09 Feb 2010 10:04:40 +0100||Entry added Tue, 09 Feb 2010 10:04:40 +0100||</detail>
        </alias>
    </aliases>

Files

Download all files
fix_alias_import.patch (4.11 KB) fix_alias_import.patch patch Perry Mason, 02/09/2010 05:20 AM
firewall_aliases_import.php (7.61 KB) firewall_aliases_import.php test file Perry Mason, 02/09/2010 05:20 AM
Actions
Copy link
 #1

Updated by Ermal Luçi about 14 years ago

  • Status changed from New to Resolved

Please next time provide more details on your patches.

I fixed this in a more reduced patchset and no need to for additional options.

Thanks for reporting.

Actions
Copy link
 #2

Updated by Perry Mason about 14 years ago

That is a irritating easy way you fix the CIDR check :-p

All though issue 1,2,3 isn't a functionality problem, I do think there is a point to them in relation to how alias create/edit works.

Without making a bikeshed I wanted my point of view noted.

Actions
Copy link

Also available in: Atom PDF