pfSense

Getting back to this.
Apparently i just made conversion code to convert any such aliases to carp on same vhid.

So i think there should be no issue here.
Upgrade code is on function upgrade_105_to_106!

that does work, but there are issues with that approach. One, you have to remember what VHID you're using on that, and pick the same, which isn't user-friendly at all. Two, the password has to be set the same on both VIPs or it'll break and there are a variety of circumstances with advskew and advbase that are similarly problematic. Three, people are accustomed to the old way in general.

Let's bring it back to where it was, and remove the upgrade code.

It should work same as before.

Applied in changeset b0d054ca3b314d0ac7dcfd6a5ba30170a71fe63b.

to me for testing

this is mostly fixed after my commits earlier, I think just one last piece. ifconfig is missing the interface. You'll end up with:

php-fpm[244]: /firewall_virtual_ip.php: The command '/sbin/ifconfig '' inet '192.168.128.254'/'32' alias vhid 201' returned exit code '1', the output was 'ifconfig: interface does not exist'

The interface is blank it seems because get_real_interface() doesn't return correctly for this circumstance.

Oops fixed!

that fixed that issue, one remaining. Config sync no longer syncs those aliases to the secondary.

that one's fixed now as well. Everything here works now.