Project

General

Profile

Actions
Copy link

Bug #4132

closed
KB

Captive Portal - Portal page contents - confusing instructions (gettext issue)

Bug #4132: Captive Portal - Portal page contents - confusing instructions (gettext issue)

Added by Kill Bill over 11 years ago. Updated over 11 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Captive Portal
Target version:
2.2
Start date:
12/19/2014
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.2
Affected Architecture:
All

Description

Make sure to include a form (POST to "") with a submit button (name="accept") and a hidden field with name="redirurl" and value=""

and below there's a code example with:

<form method="post" action="$PORTAL_ACTION$">
   ...
   <input name="redirurl" type="hidden" value="$PORTAL_REDIRURL$">
   ...
</form>

Note the actions and value certainly are not empty as suggested above. All those %#$s in gettext clearly don't work as expected.

RB Updated by Renato Botelho over 11 years ago Actions
Copy link
 #1

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:7fd7c5a5454b8b59467016b62333818e585f9187.

RB Updated by Renato Botelho over 11 years ago Actions
Copy link
 #2

Applied in changeset commit:22a7fef8b7ff2fc4f9c13b6a248912c1cf8e345b.

KB Updated by Kill Bill over 11 years ago Actions
Copy link
 #3

Thanks, though this is still incosistent - $PORTAL_ACTION/$PORTAL_REDIRURL vs. $PORTAL_ACTION$/$PORTAL_REDIRURL$ (note the trailing $s)

RB Updated by Renato Botelho over 11 years ago Actions
Copy link
 #4

Good catch, thanks!

KB Updated by Kill Bill over 11 years ago Actions
Copy link
 #5

All good now :)

RB Updated by Renato Botelho over 11 years ago Actions
Copy link
 #6

  • Status changed from Feedback to Resolved

Cool. Thanks!!

Actions
Copy link

Also available in: Atom