Project

General

Profile

Todo #4516

Improve wireless input validation

Added by Chris Buechler about 5 years ago. Updated about 5 years ago.

Status:
Resolved
Priority:
Normal
Category:
Wireless
Target version:
Start date:
03/12/2015
Due date:
% Done:

0%

Estimated time:

Description

Input validation on interfaces.php for wireless is lacking. About to push fixes, ticket for tracking.

Associated revisions

Revision bda6c6bf (diff)
Added by Chris Buechler about 5 years ago

Add more input validation for wireless parameters. Ticket #4516

Revision 95df2de5 (diff)
Added by Chris Buechler about 5 years ago

Add more input validation for wireless parameters. Ticket #4516

Revision 22ec33b9 (diff)
Added by Chris Buechler about 5 years ago

Add more validation for wireless config settings. Ticket #4516

Revision 6cd14b43 (diff)
Added by Chris Buechler about 5 years ago

Add more validation for wireless config settings. Ticket #4516

Revision aec55f9a (diff)
Added by Chris Buechler about 5 years ago

add more wireless validation. Ticket #4516

Revision 80271fb3 (diff)
Added by Chris Buechler about 5 years ago

add more wireless validation. Ticket #4516

Revision 1483a813 (diff)
Added by Chris Buechler about 5 years ago

Set txpower since that seems to work fine now. Explicitly set authmode wpa here, though it's also handled by the supplicant/authenticator. Ticket #4516

Revision ac0c4355 (diff)
Added by Chris Buechler about 5 years ago

Set txpower since that seems to work fine now. Explicitly set authmode wpa here, though it's also handled by the supplicant/authenticator. Ticket #4516

Conflicts:
etc/inc/interfaces.inc

Revision 33e85f85 (diff)
Added by Chris Buechler about 5 years ago

Require WPA PSK where WPA-PSK is enabled. Clean up some other text. Ticket #4516

Revision 310ea4e2 (diff)
Added by Chris Buechler about 5 years ago

Require WPA PSK where WPA-PSK is enabled. Clean up some other text. Ticket #4516

Revision 771ca94f (diff)
Added by Chris Buechler about 5 years ago

Default to WPA2, AES for new wireless interface configs. Ticket #4516

Revision d31517e5 (diff)
Added by Chris Buechler about 5 years ago

Default to WPA2, AES for new wireless interface configs. Ticket #4516

Revision e4909df4 (diff)
Added by Chris Buechler about 5 years ago

Default to 11ng if an option hasn't been configured. Previously we let the browser pick the first in the list (the first the card reported as available), which ended up being 802.11b. Ticket #4516

Revision 141d316c (diff)
Added by Chris Buechler about 5 years ago

Default to 11ng if an option hasn't been configured. Previously we let the browser pick the first in the list (the first the card reported as available), which ended up being 802.11b. Ticket #4516

Revision 0a950c4b (diff)
Added by Chris Buechler about 5 years ago

Apply WME input validation to all modes, not just hostap. Ticket #4516

Revision 9b65fdd0 (diff)
Added by Chris Buechler about 5 years ago

Apply WME input validation to all modes, not just hostap. Ticket #4516

Revision ae2db699 (diff)
Added by Chris Buechler about 5 years ago

txpower was disabled for good reason it would appear, it triggers syntax errors in some configurations. Disable it again since it's been disabled for years, and comment out the user-facing config portion for now since it doesn't do anything. Ticket #4516

Revision f2f34088 (diff)
Added by Chris Buechler about 5 years ago

txpower was disabled for good reason it would appear, it triggers syntax errors in some configurations. Disable it again since it's been disabled for years, and comment out the user-facing config portion for now since it doesn't do anything. Ticket #4516

History

#1 Updated by Chris Buechler about 5 years ago

  • Status changed from New to Resolved

Input validation added to most of the wireless config pieces, preventing configuration of a variety of wrong config combinations (5 GHz channels with 802.11b, for instance). Defaults updated in some cases. Requires enabling WME if an 11n mode is selected (Javascript should handle that on its own in the future). Channel auto doesn't work with hostap, so that's prohibited.

There are some possible combinations now that don't make sense to try together, but none of them that I can find break anything. All the major things should be covered. There are other possibilities for improvement in the future.

Wireless is definitely easier to deal with now, since most invalid config combinations are no longer possible.

Also available in: Atom PDF