Project

General

Profile

Bug #4976

services_unbound_acls.php is broken

Added by Chris Buechler almost 4 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Target version:
-
Start date:
08/18/2015
Due date:
% Done:

0%

Estimated time:
Spent time:

Description

Parse error: syntax error, unexpected end of file in /usr/local/www/services_unbound_acls.php on line 342

History

#1 Updated by Steve Beaver almost 4 years ago

  • Status changed from Confirmed to Feedback
  • Assignee set to Chris Buechler

Fixed error from merge.

#2 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Confirmed
  • Assignee changed from Chris Buechler to Steve Beaver

better, but still broken. Add a new ACL, hit "Add row", and you get:

Warning: array_push() expects parameter 1 to be array, null given in /usr/local/www/services_unbound_acls.php on line 83 Call Stack: 0.0001 229336 1. {main}() /usr/local/www/services_unbound_acls.php:0 0.0255 1549400 2. array_push() /usr/local/www/services_unbound_acls.php:83

#3 Updated by Steve Beaver over 3 years ago

  • Status changed from Confirmed to Assigned

Display issues resolved. Need to update the config logic to finish

#4 Updated by Steve Beaver over 3 years ago

Work in progress DO NOT TEST

#5 Updated by Steve Beaver over 3 years ago

  • Status changed from Assigned to Feedback
  • Assignee changed from Steve Beaver to Chris Buechler

A number of bugs were recorded against this page which features an editable list of networks. There are several other pages that work the same way. There is an underlying method in the O-O framework: “enableDuplication()” which can automatically add “clone” and “delete buttons” as well as replicate the selected table row.

Unfortunately the more I looked at the code, the more issues I found. Amongst other things:

  • Any IP addresses do not automatically set the mask
  • Any help text is lost if any row is deleted
  • The “Clone/duplicate” button is only added if the table is the very last item in the section
  • There is nothing to prevent anyone deleting the only row, requiring that you reload the page and start over
  • When duplicating a row, the contents of the row may, or may not be cleared depending on the input type
  • Every row get a “Duplicate” button, whereas only the last row actually needs one
  • The input label is duplicated, as well as the control, leading to a long list of identical labels where only one is required

The most efficient way to deal with all of this was to start over and create a new design which is sufficiently flexible to be used on all of the required pages, and which does not suffer from any of the above. I completed that yesterday/today and am documenting it on the WIki now. In a few minutes I will push the new services_unbound_acs.php and look forward to your review.

Once you have taken it for a spin I will update the other pages that use the same construct.

#6 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved

fixed

Also available in: Atom PDF