Project

General

Profile

Actions

Bug #5134

closed
KB

The handling of base64 encoding in the package XML is insane

Bug #5134: The handling of base64 encoding in the package XML is insane

Added by Kill Bill about 11 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Package System
Target version:
Start date:
09/14/2015
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

The XML is gonna happily swallow the <encoding>base64</encoding> tag for pretty much any field type [1] (even those where it makes absolutely no sense, such as checkbox), however, subsequently it will only decode the value for textarea tag [2]. As a result, when you use this in a package somewhere else than in textarea, the value gets base64-encoded on every save. Again, again, and again. It'd be kinda useful to be able to use for other things, such as, hmmmm... passwords that screw up the config.xml when people put special chars in there (which they frequently do).

[1] https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/pkg_edit.php#L228
[2] https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/pkg_edit.php#L738

CB Updated by Chris Buechler almost 11 years ago Actions #1

  • Status changed from New to Confirmed

Updated by Anonymous almost 11 years ago Actions #3

  • Status changed from Confirmed to Feedback

Addressed by PR 2071 now merged.

CB Updated by Chris Buechler over 10 years ago Actions #4

  • Status changed from Feedback to Resolved
  • Target version set to 2.3
Actions

Also available in: Atom