Project

General

Profile

Actions

Bug #5134

closed

The handling of base64 encoding in the package XML is insane

Added by Kill Bill about 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Package System
Target version:
Start date:
09/14/2015
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

The XML is gonna happily swallow the <encoding>base64</encoding> tag for pretty much any field type [1] (even those where it makes absolutely no sense, such as checkbox), however, subsequently it will only decode the value for textarea tag [2]. As a result, when you use this in a package somewhere else than in textarea, the value gets base64-encoded on every save. Again, again, and again. It'd be kinda useful to be able to use for other things, such as, hmmmm... passwords that screw up the config.xml when people put special chars in there (which they frequently do).

[1] https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/pkg_edit.php#L228
[2] https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/pkg_edit.php#L738

Actions #1

Updated by Chris Buechler about 6 years ago

  • Status changed from New to Confirmed
Actions #3

Updated by Steve Beaver almost 6 years ago

  • Status changed from Confirmed to Feedback

Addressed by PR 2071 now merged.

Actions #4

Updated by Chris Buechler over 5 years ago

  • Status changed from Feedback to Resolved
  • Target version set to 2.3
Actions

Also available in: Atom PDF