Project

General

Profile

Bug #5159

Javascript refactoring

Added by Steve Beaver over 3 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Target version:
Start date:
09/17/2015
Due date:
% Done:

0%

Estimated time:
4.00 h

Description

The Javascript functions hideInput, disableInput, hideClass, addRow, delRow et al have been replicated across dozens of PHP files and need to be extracted to a common include file.

History

#1 Updated by Steve Beaver over 3 years ago

  • Tracker changed from Bug to Todo

#2 Updated by Steve Beaver over 3 years ago

Include file javascript/pfSenseHelpers.js created and populated with common hide/show/disable/enable functions
Include file added to foot.inc

#3 Updated by Steve Beaver over 3 years ago

Affected files:

src/usr/local/www/diag_backup.php
src/usr/local/www/diag_logs_settings.php
src/usr/local/www/firewall_nat_edit.php
src/usr/local/www/firewall_nat_out_edit.php
src/usr/local/www/firewall_rules_edit.php
src/usr/local/www/interfaces.php
src/usr/local/www/interfaces_ppps_edit.php
src/usr/local/www/services_captiveportal.php
src/usr/local/www/services_dhcp.php
src/usr/local/www/services_dhcp_edit.php
src/usr/local/www/services_dhcpv6.php
src/usr/local/www/services_dyndns_edit.php
src/usr/local/www/services_ntpd.php
src/usr/local/www/services_ntpd_gps.php
src/usr/local/www/services_unbound.php
src/usr/local/www/system_advanced_admin.php
src/usr/local/www/system_usermanager.php
src/usr/local/www/vpn_ipsec_phase1.php
src/usr/local/www/vpn_ipsec_phase2.php
src/usr/local/www/vpn_openvpn_client.php
src/usr/local/www/vpn_openvpn_csc.php
src/usr/local/www/vpn_openvpn_server.php

#4 Updated by Steve Beaver over 3 years ago

First phase completed. (hide/show etc)
Now needs row helper functions treated similarly

#5 Updated by Steve Beaver over 3 years ago

Rowhelper pages to be updated:

usr/local/www/firewall_aliases_edit.php
usr/local/www/pkg_edit.php
usr/local/www/services_dhcp.php
usr/local/www/services_ntpd.php
usr/local/www/services_router_advertisements.php
usr/local/www/services_unbound_acls.php
usr/local/www/system_certmanager.php
usr/local/www/vpn_pppoe_edit.php

#6 Updated by Steve Beaver over 3 years ago

  • Tracker changed from Todo to Bug
  • Status changed from Confirmed to Closed

#7 Updated by Chris Buechler about 3 years ago

  • Affected Version set to 2.3

Also available in: Atom PDF