Bug #5189
closedvpn_openvpn_server dynamic input fields incorrect
100%
Description
Fields are still not right...
"Enable authentication of TLS packets." = tlsauth_enable
"Automatically generate a shared TLS authentication key" = autotls_enable
Auto Generate / "Automatically generate a shared key" = autokey_enable
Peer to Peer (SSL/TLS) Shows:
"Enable authentication of TLS packets." (OK)
"Automatically generate a shared TLS authentication key" (OK)
Auto Generate / "Automatically generate a shared key" (Should not be there)
Peer to Peer (Shared Key) Shows:
"Automatically generate a shared TLS authentication key" (Should not be there)
Auto Generate / "Automatically generate a shared key" (OK)
Remote Access (SSL/TLS) Shows:
"Enable authentication of TLS packets." (OK)
"Automatically generate a shared TLS authentication key" (OK)
Auto Generate / "Automatically generate a shared key" (Should not be there)
Remote Access (User Auth) Shows:
"Enable authentication of TLS packets." (OK)
"Automatically generate a shared TLS authentication key" (OK)
Auto Generate / "Automatically generate a shared key" (Should not be there)
Remote Access (SSL/TLS + User Auth) Shows:
"Enable authentication of TLS packets." (OK)
"Automatically generate a shared TLS authentication key" (OK)
Auto Generate (Should not be there) -- the right side bit appears to be hidden in this mode, but the left side header is still there.
Updated by Anonymous about 9 years ago
- Status changed from Assigned to Feedback
- Assignee changed from Anonymous to Jim Pingle
Actions modified to correspond with the list above
Updated by Anonymous about 9 years ago
- % Done changed from 0 to 100
Applied in changeset pfsense:27fc3a13e445f89003c23d43779a605f0172d030.
Updated by Jim Pingle about 9 years ago
- Status changed from Feedback to Assigned
- Assignee changed from Jim Pingle to Anonymous
Much better but still one small state problem.
If you have the "Automatically..." box unchecked so it shows the larger input field and then switch modes, that box stays visible.
e.g. if you have a shared key filled in and then change the mode to an SSL/TLS type, the shared key field still shows up. Same in reverse. If you had an SSL/TLS mode with a TLS Key in place and then change the mode, the TLS key box stays visible.
Updated by Anonymous about 9 years ago
- Status changed from Assigned to Feedback
- Assignee changed from Anonymous to Jim Pingle
This logic is enough to drive a person to drink.
I have made a truth table and re-coded the page to correspond to that table. I have also tested it side-by side with 2.2.4 and it appears to correspond almost exactly.
2.2.4 is not perfectly consistent when comparing initial page load, vs changing the server mode in-flight, however.
Let's review and see how this looks pls.
Updated by Anonymous about 9 years ago
Applied in changeset pfsense:97508a552c616b0f3c7569e54a017d53c5cd94f6.
Updated by Jim Pingle about 9 years ago
- Status changed from Feedback to Resolved
This looks good now, I tried a few different combinations and the correct TLS/Shared key fields appear and disappear to show up each time.