Bug #5250
closedACB backup time should display local time
100%
Description
Having some unknown TZ time displayed in the list is not exactly helpful... I'd do a pull request except that this apparently is some server payload where it comes from, no idea what to do with it, honestly.
Updated by Anonymous over 8 years ago
- Status changed from New to Confirmed
- Assignee set to Anonymous
Seems to display the time in UDT+4
Updated by Kill Bill over 8 years ago
You mean this? http://www.urbandictionary.com/define.php?term=UDT&defid=5416562
:-D
Updated by Anonymous over 8 years ago
- Status changed from Confirmed to Feedback
- Assignee changed from Anonymous to Kill Bill
Fixed
Updated by Kill Bill over 8 years ago
Not sure where's this fixed? Cannot see any update to the package, and just to be sure I made a backup and the time displayed is 6 hours off.
Updated by Anonymous over 8 years ago
- Status changed from Feedback to Assigned
- Assignee changed from Kill Bill to Anonymous
Updated by Anonymous over 8 years ago
- Status changed from Assigned to Feedback
- Assignee changed from Anonymous to Kill Bill
I must be misunderstanding the issue.
Would you clarify with step by step instructions to reproduce please?
Updated by Kill Bill over 8 years ago
It really is easy. If you find yourself outside of the unknown backup server timezone, the diplayed backup times are crap. How much crap they are depends on the offset from the unknown backup server timezone. Considering the backup list does not list a timezone, I have no idea what's the time displayed supposed to mean. ATM, the times are 6 hours off the local timezone (Central European Time).
Updated by Kill Bill over 8 years ago
Just to avoid more confusion: CET=GMT+1. (And CEST=GMT+2 -- that's the daylight saving TZ which was used until last Sunday there.)
Updated by Kill Bill over 8 years ago
These are the exact same backup; the Backup History shows correct local time, the ACB list shows unknown TZ junk. (Even the date won't match depending on when the configuration change is made.)
Updated by Anonymous over 8 years ago
So the missing information here is that you are talking about a package. I didn't realize that until I asked another team member. I should have checked the bug category :)
I'll research the matter.
Updated by Kill Bill over 8 years ago
Uhm. No idea why this bug got assigned to me. Nothing I could fix here.
Updated by Jim Pingle over 8 years ago
- Assignee changed from Kill Bill to Anonymous
That was when it was waiting for feedback from you, it should have been moved back after we got the additional info, fixed now
Updated by Kill Bill over 8 years ago
Jim P wrote:
fixed now
It's now 7 hours off, instead of 6 previously.
Guys, I have NFC what magic are you trying to do there, but may I suggest to use the Unix timestamps which can be converted locally to whatever is proper local TZ by the package?
Updated by Kill Bill over 8 years ago
LOLz... Well, unless you have had a DST switch in past two weeks, your server seems to be some sort of time travel machine. :-D
Updated by Jim Pingle over 8 years ago
- Assignee changed from Anonymous to Kill Bill
I just pushed a fix, give it a shot. Went went a fairly standard datestamp output format, feel free to submit suggestions for a different post-conversion format if the chosen one isn't OK.
Updated by Jim Pingle over 8 years ago
- % Done changed from 0 to 100
Applied in changeset commit:683f9eced9675528b61558ed327be89168b5d33f.
Updated by Kill Bill over 8 years ago
Jim P wrote:
went a fairly standard datestamp output format, feel free to submit suggestions for a different post-conversion format if the chosen one isn't OK.
Nah, RFC2822 is perfectly fine. Confirmed working, thanks :)
Updated by Jim Pingle over 8 years ago
- Status changed from Feedback to Assigned
- Assignee changed from Kill Bill to Jim Pingle
Looks like a small-ish bug, when deleting it wants the old TS, I'll keep working on it.
Updated by Jim Pingle over 8 years ago
OK fix pushed. I tested and re-tested on 2.0.x and 2.1 as well, worked OK everywhere. Changing the firewall time zone was reflected in the list as well.
Updated by Jim Pingle over 8 years ago
- Status changed from Assigned to Feedback
Applied in changeset commit:a9caf736867d5df0ff3b82c9e8500318832fa537.
Updated by Kill Bill over 8 years ago
Yeah, deleting works now as well. Probably should nuke the {$_REQUEST['rmver']} from the savemsg on line 196, since it shows something different now than what the user has confirmed, and I don't think it's worth fiddling with this to make those match.
Updated by Jim Pingle over 8 years ago
Went ahead and fixed it up there, too. It wasn't difficult to accommodate, better off this way anyhow.
Updated by Jim Pingle over 8 years ago
Applied in changeset commit:13fcabcbb24889a43afb3748bdda5e9905de1fe5.
Updated by Jim Pingle over 8 years ago
- Status changed from Feedback to Resolved
Seems fine all around here as well. Closing this out.