Project

General

Profile

Bug #5537

Editing PPP interface causes PHP error

Added by Robbert Rijkse over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
Interfaces
Target version:
Start date:
11/25/2015
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

This is pretty easy to reproduce, navigate to "Interfaces" -> "(assign)" -> PPPs. Edit or add an interface of type PPPoE.

The edit page loads with all the right settings except the password field is empty, when the page is saved without a newly entered password an input error is displayed, along with a really long list of PHP errors. Not sure what the behaviour is supposed to be. Is the password is supposed to be loaded or should it behave like the edit user page? I have attached a screen shot of the error and details of the PHP errors are below.

This also happens when a new PPPoE interface is added but I would expect that behaviour (minus the PHP errors).

This is the php error, a screen shot is attached:
Warning: explode() expects parameter 2 to be string, array given in /usr/local/www/interfaces_ppps_edit.php on line 555 Call Stack: 0.0002 337664 1. {main}() /usr/local/www/interfaces_ppps_edit.php:0 0.8543 9487712 2. build_link_list() /usr/local/www/interfaces_ppps_edit.php:619 0.8543 9513000 3. explode() /usr/local/www/interfaces_ppps_edit.php:555 Warning: in_array() expects parameter 2 to be array, null given in /usr/local/www/interfaces_ppps_edit.php on line 589 Call Stack: 0.0002 337664 1. {main}() /usr/local/www/interfaces_ppps_edit.php:0 0.8543 9487712 2. build_link_list() /usr/local/www/interfaces_ppps_edit.php:619 0.8548 9513320 3. in_array() /usr/local/www/interfaces_ppps_edit.php:589 Warning: in_array() expects parameter 2 to be array, null given in /usr/local/www/interfaces_ppps_edit.php on line 589 Call Stack: 0.0002 337664 1. {main}() /usr/local/www/interfaces_ppps_edit.php:0 0.8543 9487712 2. build_link_list() /usr/local/www/interfaces_ppps_edit.php:619 0.8551 9513504 3. in_array() /usr/local/www/interfaces_ppps_edit.php:589 Warning: in_array() expects parameter 2 to be array, null given in /usr/local/www/interfaces_ppps_edit.php on line 589 Call Stack: 0.0002 337664 1. {main}() /usr/local/www/interfaces_ppps_edit.php:0 0.8543 9487712 2. build_link_list() /usr/local/www/interfaces_ppps_edit.php:619 0.8553 9513688 3. in_array()

Selection_005.jpg (1.04 MB) Selection_005.jpg Robbert Rijkse, 11/25/2015 06:44 PM

Associated revisions

History

#1 Updated by Chris Buechler over 3 years ago

  • Status changed from New to Confirmed
  • Assignee set to Steve Beaver
  • Target version set to 2.3

#2 Updated by Steve Beaver over 3 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

#3 Updated by Steve Beaver over 3 years ago

  • Assignee changed from Steve Beaver to Robbert Rijkse

#4 Updated by Robbert Rijkse over 3 years ago

This seems to have fixed it I can save the page without any issues.

I did get a notice about this crash report after getting back to the dashboard (I submitted it):

Crash report begins.  Anonymous machine information:

amd64
10.2-STABLE
FreeBSD 10.2-STABLE #213 2572e1a(devel): Sun Nov 29 23:36:45 CST 2015 root@pfs23-amd64-builder:/usr/home/pfsense/pfsense/tmp/obj/usr/home/pfsense/pfsense/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[30-Nov-2015 16:53:07 America/Toronto] PHP Stack trace:
[30-Nov-2015 16:53:07 America/Toronto] PHP 1. {main}() /usr/local/www/interfaces_ppps_edit.php:0
[30-Nov-2015 16:53:07 America/Toronto] PHP 2. implode() /usr/local/www/interfaces_ppps_edit.php:428

Filename: /var/crash/minfree
2048

#5 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved

works

Also available in: Atom PDF