Project

General

Profile

Bug #5674

pkg_edit - XML tag 'textarea' missing rows, cols and wrap options

Added by BBcan177 . over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
12/21/2015
Due date:
% Done:

0%

Estimated time:
Affected Version:
Affected Architecture:

Description

textarea is missing code to define the rows, cols and wrap values.

(suggest setting some default values)

$rows = $pkga['rows'] ?: '10';
$cols = $pkga['cols'] ?: '50';
$wrap = $pkga['wrap'] ?: 'wrap="off style="white-space:nowr

Adding the following: (Note- cols is not being defined with this setting below).

->setAttribute('rows', $rows)
->setAttribute('cols', $cols)
->setAttribute('wrap', $wrap);

History

#1 Updated by Steve Beaver over 4 years ago

  • Status changed from New to Feedback
  • Assignee set to BBcan177 .

Just to clarify, do you mean that:

  1. 2.2.x XML allows you to specify height/width/wrapping but even though you XML contains those tags, they don't work on 2.3
  2. You are using the setAttribute() methods as shown above, but they are not working as you expected?

#2 Updated by BBcan177 . over 4 years ago

1) Looks like the same issue in 2.2.x
2) Its pkg_edit.php, so can't add any setAttribute tags to the XML files. The rows, cols, and wrap are XML tags but there is no supporting code for setAttribute in pkg_edit.

#3 Updated by Steve Beaver over 4 years ago

Added support as described.

rows, cols, and wrap tags are supported in XML via new setRows() and setCols() methods

#4 Updated by Steve Beaver over 4 years ago

  • Status changed from Feedback to Resolved

#5 Updated by BBcan177 . over 4 years ago

This can be closed.

#6 Updated by Chris Buechler over 4 years ago

Resolved is a closed status, BBcan.

#7 Updated by BBcan177 . over 4 years ago

Thanks... I sent Steve a message a few mins ago to ignore those comments... Sorry! :)

Also available in: Atom PDF