Project

General

Profile

Bug #5858

Services Status Widget - Hide Service

Added by NOYB NOYB over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Dashboard
Target version:
Start date:
02/09/2016
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

Hide service hides all services with same name. For example with multiple OpenVPN services running. Hiding one hides all. So it's all or none.

Associated revisions

Revision 7d3c67de (diff)
Added by Steve Beaver over 3 years ago

Fixed #5858
Adds an incrementing suffix to service names when there are duplicates

History

#1 Updated by Jim Thompson over 3 years ago

  • Assignee set to Steve Beaver

#2 Updated by Steve Beaver over 3 years ago

  • Status changed from New to Feedback
  • Assignee changed from Steve Beaver to NOYB NOYB

Not an easy fix. If the services have identical names, the only other option is to hide by table row number. But if you install or remove a service, the rows will now be off.

Perhaps automatically add a suffix to identical service names?

#3 Updated by Steve Beaver over 3 years ago

An incrementing suffix is added to tth service names so that they remain unique in the multiselect. e.g.:

dpinger
dpinger_2
dpinger_3

#4 Updated by Steve Beaver over 3 years ago

  • % Done changed from 0 to 100

#5 Updated by NOYB NOYB over 3 years ago

Now though it shows openvpn_2 as being down (yellow x). Guessing because there is no actual service by that name.

#6 Updated by Steve Beaver over 3 years ago

Could be. I'll investigate.

#7 Updated by Steve Beaver over 3 years ago

Just pushed a change that should help.

#8 Updated by NOYB NOYB over 3 years ago

It sees the suffixed service as being up. But cannot hide it. Only the non suffixed service can be hidden.

#9 Updated by NOYB NOYB over 3 years ago

In status services there is some code that produces a unique id and link for each of the services. Maybe that could be useful.

<a href="#" id="openvpn-restartservice-server-1" >
<a href="#" id="openvpn-restartservice-server-2" >

#10 Updated by Steve Beaver over 3 years ago

Should be OK now, but I'll check that out. Thanks.

#11 Updated by NOYB NOYB over 3 years ago

Nope. Still cannot hide openvpn_2. Returning to the config after selecting to hide, it is as though it was not selected.

Hiding the un-suffixed openvpn service works fine still though.

#12 Updated by NOYB NOYB over 3 years ago

Ah, think I missed that last commit. It's working. Thanks.

#13 Updated by Steve Beaver over 3 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF