Project

General

Profile

Actions
Copy link

Bug #6003

closed

interfaces_ppps_edit periodic reset settings not saved

Added by Phillip Davis over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Phillip Davis
Category:
-
Target version:
-
Start date:
03/16/2016
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3
Affected Architecture:

Description

Edit a PPPoE interface.
Advanced
1) Choose Periodic Reset = Custom
Enter an hour and minute in Reset Date/Time
Save
The hour and minute do not end up anywhere in the config, when you edit again they are gone.

2) Choose Periodic Reset = Pre-set
Select a reset frequency (e.g. hourly)
Save
The reset frequency does not end up anywhere in the config, when you edit again it is gone.

I haven't looked at this on 2.2.* - I just noticed it on 2.3 when doing some work on the Advanced button.
These are issues both before and after I touched the Advanced button code.

Actions
Copy link
 #1

Updated by Anonymous over 8 years ago

  • Status changed from New to Feedback
  • Assignee set to Phillip Davis

Corrected showadv logic
Corrected old issue displaying reset times
Corrected improper save by adding hidden ptpid element

Actions
Copy link
 #2

Updated by Anonymous over 8 years ago

  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Phillip Davis over 8 years ago

Works.

I noticed that if the user chooses one of the pppoe_monthly... preset reset options, then when editing the entry the advanced fields do not automagically open on page load. I fixed the test to check for this: https://github.com/pfsense/pfsense/pull/2762
(now that the preset period field actually saves, this became evident)

Actions
Copy link
 #4

Updated by Anonymous over 8 years ago

  • Status changed from Feedback to Resolved

Merged your most recent change too. Thanks.

Actions
Copy link

Also available in: Atom PDF