Project

General

Profile

Bug #6128

firewall_rules.php: Moving a rule separator before naming/saving breaks it

Added by Esa Varemo over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Start date:
04/13/2016
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

Steps to reproduce:

1. Create a new separator
2. Drag separator from bottom of the page
3. Name and Save separator

Separator does not exit edit mode, a new one appears on the bottom of the page with the saved text.

4. Save the page

Both separators, edit mode and "saved" disappear

Expected:

Either
- A separator in edit mode is not movable
- Saving a separator works even after moving

Associated revisions

Revision fee16977 (diff)
Added by Steve Beaver over 3 years ago

Fixed #6128

(cherry picked from commit e8d6c134fe44f0ad1756caa246a7c6efbbd27bbc)

History

#1 Updated by Chris Buechler over 3 years ago

  • Category changed from Rules / NAT to Web Interface
  • Target version set to 2.3.1

#2 Updated by Steve Beaver over 3 years ago

  • Assignee set to Steve Beaver

#3 Updated by Steve Beaver over 3 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#4 Updated by Steve Beaver over 3 years ago

  • Subject changed from Moving a rule separator before naming/saving breaks it to firewall_rules.php: Moving a rule separator before naming/saving breaks it
  • Assignee changed from Steve Beaver to Esa Varemo
  • % Done changed from 100 to 0

This is why developers shouldn't do QA. I would never have thought of trying that :)

Preventing the separator from moving during an edit seemed like a good idea, but it does not prevent a user from moving a firewall rule below the separator and breaking it in the same way as reported here. We could lock the entire table during edit, but that seems a bit drastic.

I have allowed a separator in edit mode to be moved and saved in place.

#5 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved

works

Also available in: Atom PDF