Project

General

Profile

Actions
Copy link

Bug #6231

closed
SN CB

Captive portal won't allow changing the voucher charset at all.

Bug #6231: Captive portal won't allow changing the voucher charset at all.

Added by sebastian nielsen over 10 years ago. Updated over 10 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Chris Buechler
Category:
Captive Portal
Target version:
2.3.1
Start date:
04/22/2016
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3
Affected Architecture:

Description

Attempting to change the charset to anything just render the error:
"The following input errors were detected:
Need at least 2 characters to create vouchers."

Example:
"ABCDEFGHIJKLMNOPQRSTUVWXYZ"

SN Updated by sebastian nielsen over 10 years ago Actions
Copy link
 #1

Found the bug. misplaced parenthis:

if ($_POST['charset'] && (strlen($_POST['charset'] < 2))) {

This causes the system to only allow digits in the voucher charset dialog.
Correct line should be:
if ($_POST['charset'] && (strlen($_POST['charset']) < 2)) {

SN Updated by sebastian nielsen over 10 years ago Actions
Copy link
 #2

forgot filename too, services_captiveportal_vouchers.php

CB Updated by Chris Buechler over 10 years ago Actions
Copy link
 #3

  • Status changed from New to Feedback
  • Assignee set to Chris Buechler

Good catch. Not sure what input you had there which caused the issue, the default character set was fine. Fix pushed

CB Updated by Chris Buechler over 10 years ago Actions
Copy link
 #4

  • Status changed from Feedback to Resolved

fixed

Actions
Copy link

Also available in: Atom