Project

General

Profile

Bug #6231

Captive portal won't allow changing the voucher charset at all.

Added by sebastian nielsen over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Category:
Captive Portal
Target version:
Start date:
04/22/2016
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.3
Affected Architecture:

Description

Attempting to change the charset to anything just render the error:
"The following input errors were detected:
Need at least 2 characters to create vouchers."

Example:
"ABCDEFGHIJKLMNOPQRSTUVWXYZ"

Associated revisions

Revision 78d8dd47 (diff)
Added by Chris Buechler over 3 years ago

Fix input validation check. Ticket #6231

Revision ebe2129d (diff)
Added by Chris Buechler over 3 years ago

Fix input validation check. Ticket #6231

History

#1 Updated by sebastian nielsen over 3 years ago

Found the bug. misplaced parenthis:

if ($_POST['charset'] && (strlen($_POST['charset'] < 2))) {

This causes the system to only allow digits in the voucher charset dialog.
Correct line should be:
if ($_POST['charset'] && (strlen($_POST['charset']) < 2)) {

#2 Updated by sebastian nielsen over 3 years ago

forgot filename too, services_captiveportal_vouchers.php

#3 Updated by Chris Buechler over 3 years ago

  • Status changed from New to Feedback
  • Assignee set to Chris Buechler

Good catch. Not sure what input you had there which caused the issue, the default character set was fine. Fix pushed

#4 Updated by Chris Buechler over 3 years ago

  • Status changed from Feedback to Resolved

fixed

Also available in: Atom PDF