Project

General

Profile

Bug #6255

PPP Country/Provider/Plan configuration not saved

Added by robi robi about 5 years ago. Updated about 5 years ago.

Status:
Confirmed
Priority:
Low
Assignee:
-
Category:
PPP Interfaces
Target version:
-
Start date:
04/25/2016
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
All
Affected Architecture:
All

Description

Using a Huawei E220 modem, but I don't think it's related to this specific model.

Go to Interfaces (assign) / PPPs / Edit
- Link type PPP
- Link interface /dev/cuaU1.0
- select proper Country/Provider/Plan: Hungary/T-Mobile/Internet
- click Save

Page hangs for about 10 seconds, and on the dashboard it shows there's a crash report.
Submitting it here too, because I'm not sure if the WAN was up when I submitted it directly from the appliance.

Crash report begins.  Anonymous machine information:

amd64
10.3-RELEASE
FreeBSD 10.3-RELEASE #6 05adf0a(RELENG_2_3_0): Mon Apr 11 18:52:07 CDT 2016 root@ce23-amd64-builder:/builder/pfsense-230/tmp/obj/builder/pfsense-230/tmp/FreeBSD-src/sys/pfSense

Crash report details:

PHP Errors:
[25-Apr-2016 08:56:36 Etc/UTC] PHP Stack trace:
[25-Apr-2016 08:56:36 Etc/UTC] PHP 1. {main}() /usr/local/www/interfaces_ppps_edit.php:0
[25-Apr-2016 08:56:36 Etc/UTC] PHP 2. implode() /usr/local/www/interfaces_ppps_edit.php:399
[25-Apr-2016 08:56:36 Etc/UTC] PHP Stack trace:
[25-Apr-2016 08:56:36 Etc/UTC] PHP 1. {main}() /usr/local/www/interfaces_ppps_edit.php:0
[25-Apr-2016 08:56:36 Etc/UTC] PHP 2. implode() /usr/local/www/interfaces_ppps_edit.php:400

Country/Provider/Plan are not saved on the webgui, it defaults back to Afghanistan/(empty)/(empty). It's defaulted to empty on both interfaces.php and interfaces_ppps_edit.php.

Examining config.xml, Country/Provider/Plan are missing from it, but apn and phone are present.

It's also confusing that PPP Configuration (related to Country/Provider/Plan) is present in both interfaces.php and interfaces_ppps_edit.php
IMHO it should only appear in interfaces_ppps_edit.php, in interfaces.php perhaps should only be a link pointing to interfaces_ppps.php, if interface type is PPP.

If Country/Provider/Plan are not saved in the config.xml by design - that's fine, but in that case there are some observations, to avoid confusion. It's confusing to see pre-selected another county when re-visiting the page later.
- if service provider data is set, the Country/Provider/Plan fields should be hidden behind a button named "Display provider presets"
- the Country list should not default to any country (this case Afghanistan), it should contain a first empty entry maybe with text "<Select to fill in service provider data>" pre-selected (but empty value behind)
- the description should contain an explanation that Country/Provider/Plan field values are not saved in the config, they are only presented in the web interface to ease the service provider data completion

Also I noticed that Advanced options are open by default, this section should be closed by default.

History

#1 Updated by Chris Buechler about 5 years ago

  • Subject changed from PPP Country/Provider/Plan configuration not saved for USB modem; apparing twice in the WebUI; resets to Afghanistan; Advanced options always open to PPP Country/Provider/Plan configuration not saved
  • Status changed from New to Confirmed
  • Priority changed from High to Low
  • Target version deleted (2.3.1)
  • Affected Version changed from 2.3 to All

moved the PHP error to #6264.

The advanced options are only expanded if you have one of them configured, they're not by default.

The country/provider/plan has never been saved, that could be handled better. I think that's the only issue here.

Also available in: Atom PDF