Bug #6378
closed
inline background styles in squidguard package
0%
Description
When you look at squidguard's Target Category list (assuming it's populated), the text is too faint as compared to the light-grey cell colour.
source: https://forum.pfsense.org/index.php?topic=110979.msg624599
It looks like the bootstrap classes haven't been applied. Some of the files with hard coded styles include:
https://github.com/pfsense/FreeBSD-ports/blob/devel/www/pfSense-pkg-squidGuard/files/usr/local/pkg/squidguard.inc
https://github.com/pfsense/FreeBSD-ports/blob/devel/www/pfSense-pkg-squidGuard/files/usr/local/pkg/squidguard_acl.xml
https://github.com/pfsense/FreeBSD-ports/blob/devel/www/pfSense-pkg-squidGuard/files/usr/local/pkg/squidguard_default.xml
https://github.com/pfsense/FreeBSD-ports/blob/devel/www/pfSense-pkg-squidGuard/files/usr/local/pkg/squidguard_dest.xml
Updated by Jared Dillard
Updated by Kill Bill over 7 years ago
Anyone filling bugs about this package should consider a bounty to get it rewritten from scratch. I guess nothing short of $1K would get things started. Whatever still keeps working in this package is a huge miracle and reading the code gives people an instant headache, to put it mildly. (And most certainly, noone should code things when on gallons of Russian vodka.)
I don't think it's a good idea to bring this mess over to 2.4.
Updated by Kill Bill over 6 years ago
Someone kindly merge this PR and call it a day. https://github.com/pfsense/FreeBSD-ports/pull/385
It makes things readable for now and noone is daring to touch the code otherwise.
Updated by Viktor Gurov over 3 years ago
Updated by Renato Botelho over 3 years ago
- Status changed from New to Feedback
PR has been merged. Thanks!