pfSense » pfSense Packages

And a merry frickin' Christmas to you too :)

Looking at this now.

Thanks. Yours truly Santa. :-P

Thanks, much appreciated! Will test with a new snapshot ASAP.

Remember to update BOTH Squid from the package manager, AND the base system from the Update manager.

Steve Beaver wrote:

There was a bug in pkg_edit.php that was causing the \<onchange\> XML tag to be rendered incorrectly,

Can we get this to RELENG_2_3 please?

Should be there already

OK, tested. The authentication tab works great. The antivirus stuff is quirky, will need to play with it. Most issues seem to be due to the advancedfield thing.

On a quick look at pkg_edit.php, there are probably quite a few more bugs, for instance, no idea what's this supposed to do:

- https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/pkg_edit.php#L1112
- https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/pkg_edit.php#L1296

I'd say it should be if ($grouping) like everywhere else.

Yep. Revised that yesterday. The Antivirus stuff appears to work as designed, but that design may not be ideal. It's confusing when JS disables/enables fields that are currently hidden.

Steve Beaver wrote:

Yep. Revised that yesterday. The Antivirus stuff appears to work as designed, but that design may not be ideal. It's confusing when JS disables/enables fields that are currently hidden.

Well the good think is that it appears to clear the advanced config now on save when you switch it to disabled (which was broken before your fixes.) Getting rid of the 'advanced' tags in XML got rid of the weird behaviour, except that I'd need an "onload" (not onchange) function that would keep the advanced fields disabled when you load the tab when "Enable Manual Configuration" is disabled. Is that somehow doable with XML?

I think that happens now. The XML fragment

    <custom_php_after_form_command>
        squid_print_antivirus_advanced_config2();
    </custom_php_after_form_command>

Sets the enable/disable state based on the selector setting, and it seems to work for me

Well, that's kinda difficult to see with the package as is. :) What I did for testing was nuking all the "advanced" tag stuff in the XML. After that, all the advanced fields are visible all the time and yes, you can see they get toggled with Enable/Disable changes. But when you initially load the tab with Enable Manual Configuration set to Disabled, the raw config textarea fields are not disabled.

Can you describe"the weird behaviour" please? I don't see anything untoward. Also what Browser/OS are you using?

The

    <custom_php_after_form_command>
        squid_print_antivirus_advanced_config2();
    </custom_php_after_form_command>

Thing was not working because it was being executed before the page had finished loading. I have fixed that and bumped Squid to 0.4.28 The form elements are now properly enabled/disabled on page load.

Yeah, 0.4.28 behaves like it used to works on pfSense 2.2.x, all weirdness gone. Very cool. Thanks!!!

A new bug is revelead, see:

The syntax is duplicated.

New installation from 2.3.2 version with last package version from Squid.

None of those fixes are in 2.3.2 so it's just pointless to test anything there.

Right. It is not "A new bug", it is the original bug that has just been fixed.

Steve Beaver wrote:

Right. It is not "A new bug", it is the original bug that has just been fixed.

https://github.com/pfsense/pfsense/commit/a038b8166a332579112f52639fd5ac03b5f76565