Project

General

Profile

Actions

Bug #7230

closed

wizard.php - update_config_field() uses eval to set a value in a way that allows variable protections to be bypassed

Added by Jim Pingle almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Urgent
Assignee:
Category:
Web Interface
Target version:
Start date:
02/07/2017
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

update_config_field() in wizard.php needs to use eval to construct a variable name that is several array levels deep. The problem lies in the way the value is set for this variable, it can be bypassed in various ways, including using passthru to escape addslashes.

It's easiest to test by using the OpenVPN wizard, get to the step with the interface selection and use firebug to alter the interface value to be"

wan";echo exec("id");" 

Actions #1

Updated by Jim Pingle almost 5 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100
Actions #2

Updated by Jim Pingle almost 5 years ago

  • Status changed from Feedback to Resolved

Fixed

Actions #3

Updated by Jim Pingle almost 5 years ago

  • Target version changed from 2.4.0 to 2.3.3
Actions #4

Updated by Jim Pingle over 4 years ago

  • Private changed from Yes to No
Actions #5

Updated by Jim Pingle over 4 years ago

  • Private changed from No to Yes
Actions #6

Updated by Jim Pingle over 4 years ago

  • Private changed from Yes to No
Actions

Also available in: Atom PDF