Project

General

Profile

Bug #7434

Traffic shaper wizard: SMB choice uses invalid destination port range

Added by Jim Pingle 30 days ago. Updated 30 days ago.

Status:
Feedback
Priority:
Normal
Assignee:
Category:
Traffic Shaper
Target version:
Start date:
03/27/2017
Due date:
% Done:

100%

Affected version:
All
Affected Architecture:
All

Description

The ports for SMB used by the traffic shaper are defined in /etc/inc/wizardapp.inc, and they are defined incorrectly. The fields are a low and high destination port, but the definition for SMB lists low-high in both fields. This results in a rule with "137-139-137-139" in its settings, which is invalid.

The new validation code to reject invalid port aliases and ranges made the error visible.

Associated revisions

Revision 02c3646f
Added by Jim Pingle 30 days ago

Correct definition of ports for SMB used by the shaper wizard. Fixes #7434

Revision f15da5f3
Added by Jim Pingle 30 days ago

Correct definition of ports for SMB used by the shaper wizard. Fixes #7434

Revision d90321c0
Added by Jim Pingle 30 days ago

Correct definition of ports for SMB used by the shaper wizard. Fixes #7434

History

#1 Updated by Jim Pingle 30 days ago

I pushed a fix, but now I'm wondering if we might want some upgrade code to fix the existing broken rules. Since it was made by the wizard, there are bound to be quite a few of these broken rules out there.

#2 Updated by Jim Pingle 30 days ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100

Also available in: Atom PDF