Bug #7434
Traffic shaper wizard: SMB choice uses invalid destination port range
100%
Description
The ports for SMB used by the traffic shaper are defined in /etc/inc/wizardapp.inc, and they are defined incorrectly. The fields are a low and high destination port, but the definition for SMB lists low-high in both fields. This results in a rule with "137-139-137-139" in its settings, which is invalid.
The new validation code to reject invalid port aliases and ranges made the error visible.
Associated revisions
Correct definition of ports for SMB used by the shaper wizard. Fixes #7434
Correct definition of ports for SMB used by the shaper wizard. Fixes #7434
Correct definition of ports for SMB used by the shaper wizard. Fixes #7434
Work around broken wizard rules for ticket #7434
Add upgrade code to work around broken shaper rules from old wizard code. Ticket #7434
History
#1
Updated by Jim Pingle 5 months ago
I pushed a fix, but now I'm wondering if we might want some upgrade code to fix the existing broken rules. Since it was made by the wizard, there are bound to be quite a few of these broken rules out there.
#2
Updated by Jim Pingle 5 months ago
- Status changed from Assigned to Feedback
- % Done changed from 0 to 100
Applied in changeset 02c3646f36f84bfe1a65c54c38a05e100e8abd44.
#3
Updated by Jim Pingle 4 months ago
- Status changed from Feedback to Resolved
To fix the broken wizard rules, I added a workaround in the filter reload process on 2.3.x because upgrade code would be problematic there. I added some upgrade code on 2.4 to fix it properly.