Project

General

Profile

Actions

Bug #7434

closed

Traffic shaper wizard: SMB choice uses invalid destination port range

Added by Jim Pingle over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Traffic Shaper (ALTQ)
Target version:
Start date:
03/27/2017
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

The ports for SMB used by the traffic shaper are defined in /etc/inc/wizardapp.inc, and they are defined incorrectly. The fields are a low and high destination port, but the definition for SMB lists low-high in both fields. This results in a rule with "137-139-137-139" in its settings, which is invalid.

The new validation code to reject invalid port aliases and ranges made the error visible.

Actions #1

Updated by Jim Pingle over 4 years ago

I pushed a fix, but now I'm wondering if we might want some upgrade code to fix the existing broken rules. Since it was made by the wizard, there are bound to be quite a few of these broken rules out there.

Actions #2

Updated by Jim Pingle over 4 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100
Actions #3

Updated by Jim Pingle over 4 years ago

  • Status changed from Feedback to Resolved

To fix the broken wizard rules, I added a workaround in the filter reload process on 2.3.x because upgrade code would be problematic there. I added some upgrade code on 2.4 to fix it properly.

Actions

Also available in: Atom PDF