Project

General

Profile

Bug #7445

pfSenseHelpers.js service naming restrictions plus lack of error handling

Added by Kill Bill 7 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Start date:
04/02/2017
Due date:
% Done:

100%

Affected version:
2.3.x
Affected Architecture:
All

Description

Code in pfSenseHelpers.js [1] introduced probably in this commit [2]
[1] https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/js/pfSenseHelpers.js#L658-L659
[2] https://github.com/pfsense/pfsense/commit/29fda3d3cea4bd800568f82a1203db8cd13a82e2

in effect restricts services names so that they cannot contain a hyphen:

This breaks the functionality in Status > Services and Services Status widget for (at least) the following packages:
- pfSense-pkg-net-snmp
- pfSense-pkg-squid
- pfSense-pkg-FTP_Client_Proxy

See https://github.com/pfsense/FreeBSD-ports/pull/336 for discussion.

Besides the undocumented restriction hidden in totally unexpected places, the AJAX stuff there lacks any error handling, so people are just scratching their heads about WTH a dead simple button does not produce any action.

Associated revisions

Revision 21a8edd7
Added by Steve Beaver 7 months ago

Fixed #7445
Now properly handles service names that contain hyphens

Revision a0ef9714
Added by Steve Beaver 7 months ago

Fixed #7445
Now properly handles service names that contain hyphens

(cherry picked from commit 21a8edd7836baf1e4ee2f347fdc1bafb4d96c9d9)

History

#1 Updated by Jim Thompson 7 months ago

  • Assignee set to Steve Beaver

#2 Updated by Steve Beaver 7 months ago

  • Status changed from New to Feedback

Now properly handles service names that contain hyphens

#3 Updated by Steve Beaver 7 months ago

  • % Done changed from 0 to 100

#4 Updated by Steve Beaver 6 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF