Bug #7445: pfSenseHelpers.js service naming restrictions plus lack of error handling - pfSense - pfSense bugtracker

Actions

Copy link

Bug #7445

closed

pfSenseHelpers.js service naming restrictions plus lack of error handling

Added by Kill Bill over 7 years ago. Updated over 7 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Category:

Web Interface

Target version:

2.3.4

Start date:

04/02/2017

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

Release Notes:

Affected Version:

2.3.x

Affected Architecture:

All

Description

Code in pfSenseHelpers.js [1] introduced probably in this commit [2]
[1] https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/js/pfSenseHelpers.js#L658-L659
[2] https://github.com/pfsense/pfsense/commit/29fda3d3cea4bd800568f82a1203db8cd13a82e2

in effect restricts services names so that they cannot contain a hyphen:

This breaks the functionality in Status > Services and Services Status widget for (at least) the following packages:
- pfSense-pkg-net-snmp
- pfSense-pkg-squid
- pfSense-pkg-FTP_Client_Proxy

See https://github.com/pfsense/FreeBSD-ports/pull/336 for discussion.

Besides the undocumented restriction hidden in totally unexpected places, the AJAX stuff there lacks any error handling, so people are just scratching their heads about WTH a dead simple button does not produce any action.