Project

General

Profile

Actions

Bug #7634

closed

When restoring from USB during install, if the config file contains RRD data, the final config.xml on the system will also contain all the RRD infomation

Added by robi robi almost 7 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Backup / Restore
Target version:
Start date:
06/09/2017
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

When restoring from USB during install (according to https://doc.pfsense.org/index.php/Automatically_Restore_During_Install), if the config file contains RRD data, the final config.xml on the system will also contain all the RRD infomation.

It's going to store all the RRD information which was present at the backup time, between the <rrddata></rrddata> tags at the end of the file, and this file will be the main config file of the system as it is.
RRD information is not restored though.
Configuration saves take longer because of this.

Backing up the configuration from the web interface using the default "Do not backup RRD data (NOTE: RRD Data can consume 4+ megabytes of config.xml space!)" ticked, will still result in an XML file containing the RRD information.

Purging manually all the data between <rrddata></rrddata> and the tags themselves, then restoring the config from the web interface will reboot the firewall, RRD data will still be lost, but at least the config file size will be back to normal.

Actions #1

Updated by robi robi almost 7 years ago

I had this with an XML 10MB in size.
If this cannot be fixed, please post a warning in the documentation (page linked above) so that people should not use the XML containing RRD when restoring during install.

Actions #2

Updated by Jim Pingle almost 7 years ago

  • Category set to Backup / Restore
  • Target version changed from 2.3.4-p1 to 2.3.5
  • Affected Architecture All added
  • Affected Architecture deleted ()

Looks like there isn't any code to handle restoring RRD in that PFI path, only when diag_backup.php is used.

The feature during the installation process isn't present on 2.4 currently, so this bug would only be relevant to the next release with the feature in an installer, 2.3.5.

Actions #3

Updated by robi robi almost 7 years ago

Is this feature left out intentionally from the future versions?

It's very handy. It allowed me to restore a firewall with a broken SSD without having to hook up a VGA screen and a keyboard and assign interfaces.

Actions #4

Updated by Jim Pingle almost 7 years ago

robi robi wrote:

Is this feature left out intentionally from the future versions?

The installer was changed completely, so features like that will need to be reimplemented if they are to be kept. We're still looking into options there but I doubt it will be in 2.4, maybe 2.4.1.

It's very handy. It allowed me to restore a firewall with a broken SSD without having to hook up a VGA screen and a keyboard and assign interfaces.

You'd still need a console to go through the installer (especially on 2.4).

Actions #5

Updated by robi robi almost 7 years ago

OK, I vote for it to be re-implemented in future versions, this is a very handy feature to have.

Actions #6

Updated by Jim Pingle over 6 years ago

  • Target version changed from 2.3.5 to 2.4.3
  • Affected Version changed from 2.3.4 to All
Actions #7

Updated by Jim Pingle over 6 years ago

FYI- The PFI/Restore feature was put back in the installer, but this RRD issue likely still persists. It needs retested on 2.4.3 snapshots at least, there have been more RRD/Restore changes there.

Actions #8

Updated by Anonymous about 6 years ago

  • Assignee set to Anonymous
Actions #9

Updated by Jim Pingle about 6 years ago

  • Target version changed from 2.4.3 to 2.4.4
Actions #10

Updated by Anonymous almost 6 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Added a piece in the PFI to remove rrddata when restoring from a USB config during install. b76e6a64c0b948808a0260f4ce702f2e8866de86

Actions #11

Updated by Anonymous almost 6 years ago

On 2.4.4.a.20180707.0234 works as expected. RRD data is removed from the config.xml that is restored during PFI.

Actions

Also available in: Atom PDF