Project

General

Profile

Actions

Bug #7649

closed

pkg_edit.php - The last row cannot be deleted with ntopng.xml

Added by Kill Bill almost 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
-
Start date:
06/16/2017
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.3.4
Affected Architecture:
All

Description

When I click on "Delete data" button in Diagnostics - ntopng Settings, I only get "the last row cannot be deleted" pop-up. The relevant code here [1], no idea what "row" is it referring to.

[1] https://github.com/pfsense/FreeBSD-ports/blob/devel/net/pfSense-pkg-ntopng/files/usr/local/pkg/ntopng.xml#L163

Actions #1

Updated by Kill Bill almost 7 years ago

Eh, linked wrong line: https://github.com/pfsense/FreeBSD-ports/blob/devel/net/pfSense-pkg-ntopng/files/usr/local/pkg/ntopng.xml#L176

<button class="btn btn-warning btn-sm" name='Delete' id='delete_ntopng_data' type='submit' value='Delete Data'><i class="fa fa-trash icon-embed-btn"></i>Delete Data</button>
Actions #2

Updated by Jim Pingle almost 7 years ago

  • Assignee set to Jim Pingle

It doesn't like that the element id has "delete" in it and it isn't part of a repeatable/rowhelper control.

If you change the ID to something like "remove_ntopng_data" it works without producing the error. Since the ID is not important for how ntopng is using the buttton, I'd say that's the best way to fix this issue.

Actions #3

Updated by Jim Pingle almost 7 years ago

  • Target version deleted (2.3.4-p1)
Actions #4

Updated by Jim Pingle almost 7 years ago

  • Status changed from New to Feedback

New version of ntopng with a renamed ID is building now.

Actions #5

Updated by Kill Bill almost 7 years ago

Works (just edited manually for a quick test).

Actions #6

Updated by Jim Pingle almost 7 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF