Project

General

Profile

Bug #7789

GIF interface page does not validate IPv6 addresses

Added by Greg Toombs 4 months ago. Updated about 2 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Interfaces
Target version:
Start date:
08/21/2017
Due date:
% Done:

100%

Affected Version:
2.3.4_1
Affected Architecture:
amd64

Description

The following field (and maybe others) seem not to be properly validated:

GIF tunnel local address
GIF tunnel remote address

I entered a "/64" at the end of both of these fields, and it appeared to save successfully, but then failed at this step:

php-fpm 12554 /system.php: The command '/sbin/route change -host -inet6 2001:xxx:xx::2 2001:xxx:xxxx:xxx::1/64' returned exit code '71', the output was 'route: 2001:xxx:xxxx:xxx::1/64: hostname nor servname provided, or not known'

Fixing my mistake - removing /64 from those fields, disabling and re-enabling the gateway - fixed the problem; but it should have been caught sooner, at the GIF page.

Associated revisions

Revision 6d028dc2
Added by Jim Pingle 4 months ago

When saving a GIF interface, do not allow the user to enter a subnet directly in the address box. The subnet is determined by the "GIF tunnel subnet" drop-down. Fixes #7789

Revision c7fd6ec9
Added by Jim Pingle 4 months ago

When saving a GIF interface, do not allow the user to enter a subnet directly in the address box. The subnet is determined by the "GIF tunnel subnet" drop-down. Fixes #7789

(cherry picked from commit 6d028dc26c129ce1b0b25551142819772664f1e5)

Revision df4107ac
Added by Jim Pingle 4 months ago

When saving a GIF interface, do not allow the user to enter a subnet directly in the address box. The subnet is determined by the "GIF tunnel subnet" drop-down. Fixes #7789

(cherry picked from commit 6d028dc26c129ce1b0b25551142819772664f1e5)
(cherry picked from commit c7fd6ec9b196b0d7c37d14dad13f745dab82420d)

Revision ba7bc25c
Added by Jim Pingle 4 months ago

When saving a GIF interface, do not allow the user to enter a subnet directly in the address box. The subnet is determined by the "GIF tunnel subnet" drop-down. Fixes #7789

(cherry picked from commit 6d028dc26c129ce1b0b25551142819772664f1e5)
(cherry picked from commit c7fd6ec9b196b0d7c37d14dad13f745dab82420d)
(cherry picked from commit df4107ac10793cacfa484e2856abafd2afac7d0d)

History

#1 Updated by Jim Pingle 4 months ago

  • Category changed from Gateways to Interfaces
  • Status changed from New to Confirmed
  • Assignee set to Jim Pingle
  • Target version set to 2.3.4_2

It is validating IPv4/IPv6 addresses but it also happens to also validate subnets as valid addresses. I'll push a fix momentarily.

#2 Updated by Jim Pingle 4 months ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

#3 Updated by Jim Pingle about 2 months ago

  • Status changed from Feedback to Resolved
  • Target version changed from 2.3.4_2 to 2.3.5

Also available in: Atom PDF