Project

General

Profile

Actions
Copy link

Bug #7854

closed
RS JP

OpenVPN Remote Access Server Setup Wizard - Regex too strict

Bug #7854: OpenVPN Remote Access Server Setup Wizard - Regex too strict

Added by Ryan Skinner about 9 years ago. Updated almost 9 years ago.

Status:
Resolved
Priority:
Very Low
Assignee:
Jim Pingle
Category:
OpenVPN
Target version:
2.4.0
Start date:
09/11/2017
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:

Description

In the OpenVPN Remote Access Server Setup Wizard, when trying to input a valid email, "The following input errors were detected:
Please limit Certificate field names to only the following characters: A-Z, a-z, space, underscore, and dash."

Upon removal of any input in E-mail field: "Please enter all information for the new Certificate Authority."

Cannot Add new CA on this screen.

KB Updated by Kill Bill about 9 years ago Actions
Copy link
 #1

Must be something else than email, that message is for country/state/city/organization.

https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/wizards/openvpn_wizard.inc#L312

JP Updated by Jim Pingle almost 9 years ago Actions
Copy link
 #2

  • Category set to OpenVPN
  • Status changed from New to Confirmed
  • Assignee set to Jim Pingle
  • Target version set to 2.4.1
  • Affected Version set to All

In light of #7540 all of that validation probably does need to be revisited soonish. There are relatively few restrictions now, the wizard will need to catch up.

JP Updated by Jim Pingle almost 9 years ago Actions
Copy link
 #3

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:00d5594c737d475abab8e0361bb3ff7f93b98ac8.

JP Updated by Jim Pingle almost 9 years ago Actions
Copy link
 #4

  • Target version changed from 2.4.1 to 2.4.0

After inspecting the code, this was a bit easier than I expected it to be, so I pushed a fix.

JP Updated by Jim Pingle almost 9 years ago Actions
Copy link
 #5

  • Status changed from Feedback to Resolved

The wizard now allows the user to use any characters they want in certificate fields and escapes them properly before creating the CA/Certs, just like the certificate manager does directly.

Actions
Copy link

Also available in: Atom