Project

General

Profile

Actions

Bug #8074

closed

Captive Portal RADIUS WISPr-Bandwith-Up value used incorrectly creating Limited rules

Added by Richard Gate over 6 years ago. Updated over 6 years ago.

Status:
Duplicate
Priority:
High
Assignee:
-
Category:
Captive Portal
Target version:
-
Start date:
11/09/2017
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
Affected Architecture:

Description

Since pfSense 2.4.0 and the re-write of Captive Portal, the RADIUS WISPr-Bandwidth-Up value is being used incorrectly when setting up limiter bandwidth values.

The following is an example of the WISPr-Bandwidth-Up values and the limited bandwidth created;
262144000 -> 26.144Mbps
26214400 -> 26.214Kbps
2621440 -> 2.62Kbps
262144 -> 262bps

WISPr-Bandwidth-Up should be bits per second. So a value of 262144 should be 26.214Kbps NOT 262bps.
This causes uses upload bandwidth to be severely limited and unusable.

Actions #1

Updated by Richard Gate over 6 years ago

Sorry should have set the Affected Version to 2.4.0

Actions #2

Updated by Richard Gate over 6 years ago

Some more info.
I also get this problem in version 2.4.1
I've been looking at the code in /etc/inc/captiveportal.inc in function poral_allow() around line 2303 where pfSense_ipfw_pipe() is usded.
If I put som logging in there the value for $bw_up is correct at 262.
If I hard code the bandwidth, it works ok.
So change - $_gb = @pfSense_ipfw_pipe("pipe {$bw_up_pipeno} config bw {$bw_up}Kbit/s queue 100 buckets 16");
to - $_gb = @pfSense_ipfw_pipe("pipe {$bw_up_pipeno} config bw 262Kbit/s queue 100 buckets 16");

Actions #3

Updated by Jim Pingle over 6 years ago

  • Status changed from New to Duplicate

I didn't notice this one, but the description was not quite right. The real bug is in #8097 and there is a fix in 2.4.2 for it now.

Actions #4

Updated by Richard Gate over 6 years ago

Thanks, yes I must have typed that too fast, fingers going faster than brain :-)

Actions

Also available in: Atom PDF