Project

General

Profile

Bug #8095

Unescaped simple quotes break JavaScript features when the French translation is enabled

Added by Marin Bernard about 2 years ago. Updated 4 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Translations
Target version:
-
Start date:
11/15/2017
Due date:
% Done:

0%

Estimated time:
Affected Version:
2.4.1
Affected Architecture:
All

Description

Hi,

In pfSense 2.4.1-RELEASE, the French translation includes several strings with unescaped simple quotes, which cause JavaScript syntax errors breaking interactive UI features.
This issue is present on the firewall rule edit page. It may also cause bugs on other pages.
Firefox and Chrome both report syntax errors:

SyntaxError: missing } after property list in firewall_rules_edit.php:1018:22

Which leads to the following JS structure with unescaped simple quotes:

var icmptypes = [];
icmptypes['inet'] = {
    'any':'tout',
    'althost':'Hôte alternatif',
    'dataconv':'Erreur de conversion de datagramme',
    'echorep':'Réponse Echo',
    'echoreq':'Requête Echo',
    'inforep':'Information répondue',
    'inforeq':'Requête d'information',
    'ipv6-here':'IPv6 Je-suis-là',
    'ipv6-where':'IPv6 Où-es-tu',
    'maskrep':'Masque d'adresse de réponse',
    'maskreq':'Masque d'adresse de requête',
    'mobredir':'Redirection de l’hôte mobile',
    'mobregrep':'Réponse de l'enregistrement mobile',
    'mobregreq':'Requête d'enregistrement mobile',
    'paramprob':'Problème de paramètre (entête IP invalide)',
    'photuris':'Photuris',
    'redir':'Rediriger',
    'routeradv':'Avertissement du routeur',
    'routersol':'Sollicitation du routeur',
    'skip':'Passer',
    'squench':'Source épuisée',
    'timerep':'Horodatage de la réponse',
    'timereq':'Horodatage',
    'timex':'Temps dépassé',
    'trace':'Traceroute',
    'unreach':'Destination inaccessible'
};

History

#1 Updated by Jim Pingle 4 months ago

  • Category changed from Web Interface to Translations

Also available in: Atom PDF