Project

General

Profile

Actions
Copy link

Bug #8159

closed

services_dnsmasq.php: Deleting a Host Override entry removes the wrong item

Added by Jim Pingle about 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
DNS Forwarder
Target version:
2.4.2-p1
Start date:
12/04/2017
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.2
Affected Architecture:
All

Description

On Services > DNS Forwarder, when there are multiple Host Override entries the wrong item can be deleted from the list.

It may be related to how the items are sorted before display or before deleting. On a test VM here, hovering over the delete icon shows the IDs are not in order as if the list was sorted, for example:

aaaaa id=0
bbbbb id=3
ccccc id=1
ddddd id=2

Clicking the delete icon for entry "ccccc" actually removes "bbbbb".

The id numbers reflect the actual order of the entries in config.xml, which is unsorted.

Actions
Copy link
 #1

Updated by Anonymous about 7 years ago

  • Assignee changed from Anonymous to Anonymous

I think there was a recent PR that added sorting. That probably broke the relationship between the list and the indices.

Actions
Copy link
 #2

Updated by Anonymous about 7 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100
Actions
Copy link
 #3

Updated by Jim Pingle about 7 years ago

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom PDF