Project

General

Profile

Bug #8159

services_dnsmasq.php: Deleting a Host Override entry removes the wrong item

Added by Jim Pingle over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
High
Assignee:
-
Category:
DNS Forwarder
Target version:
Start date:
12/04/2017
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Default
Affected Version:
2.4.2
Affected Architecture:
All

Description

On Services > DNS Forwarder, when there are multiple Host Override entries the wrong item can be deleted from the list.

It may be related to how the items are sorted before display or before deleting. On a test VM here, hovering over the delete icon shows the IDs are not in order as if the list was sorted, for example:

aaaaa id=0
bbbbb id=3
ccccc id=1
ddddd id=2

Clicking the delete icon for entry "ccccc" actually removes "bbbbb".

The id numbers reflect the actual order of the entries in config.xml, which is unsorted.

Associated revisions

Revision 581c2d5f (diff)
Added by Stephen Jones over 3 years ago

Fixed #8159 added a sort by index after a delete call has been made to make sure it lines up correctly.

Revision c254f9b4 (diff)
Added by Stephen Jones over 3 years ago

Fixed #8159 added a sort by index after a delete call has been made to make sure it lines up correctly.

Revision 1e659e02 (diff)
Added by Stephen Jones over 3 years ago

Fixed #8159 added a sort by index after a delete call has been made to make sure it lines up correctly.

Revision aed8febb (diff)
Added by Stephen Jones over 3 years ago

Backported for bug #8159 so sort by index before deleting to delete the correct one

Revision 90ac6971 (diff)
Added by Stephen Jones over 3 years ago

Backported for bug #8159 so sort by index before deleting to delete the correct one

History

#1 Updated by Steve Beaver over 3 years ago

  • Assignee changed from Steve Beaver to Anonymous

I think there was a recent PR that added sorting. That probably broke the relationship between the list and the indices.

#2 Updated by Anonymous over 3 years ago

  • Status changed from Confirmed to Feedback
  • % Done changed from 0 to 100

#3 Updated by Jim Pingle over 3 years ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF