Project

General

Profile

Bug #8164

PPPoE Server and L2TP Server Login Event Log is not functional

Added by Jim Pingle almost 3 years ago. Updated almost 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
VPN (Multiple Types)
Target version:
Start date:
12/05/2017
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.x
Affected Architecture:
All

Description

Both the PPPoE server and L2TP server rely on vpn.log to track login/logout events. On 2.4.x these logs are not functioning as expected.

Both services use /usr/local/sbin/vpn-linkup and /usr/local/sbin/vpn-linkdown to track the events, relying on mpd to pass the required information.

On previous versions, the interface used by mpd was specific to the service. For example, for L2TP the interfaces were l2tp0, l2tp1 and so on. For PPPoE server they were poes0, poes1, and so on. For both on 2.4.x these are now simply ng0, ng1, etc.

Since the interface isn't specific, the log parsing code can't find the events and correlate them to the proper service.

  • None of the parameters passed from mpd to the linkup and linkdown scripts indicate the type of service.
  • Adding a parameter to the mpd link script doesn't work either since it expects a single command to be specified.
  • Trying to track by the interface group of ngX doesn't work at login because the interface does not yet exist.
  • Using "set iface name l2tp" doesn't work at login, mpd still passes ngX to the linkup script.

So far the best workaround I've come up with is to make a separate linkup/down script for l2tp and poes which then passes the correct parameters to the actual link up/down script.

Associated revisions

Revision 902a31e3 (diff)
Added by Jim Pingle almost 3 years ago

Fix logging for L2TP and PPPoE server login/logout events. Fixes #8164

See https://redmine.pfsense.org/issues/8164 for the reasoning about why it was done this way.

Revision 6ee7e27a (diff)
Added by Jim Pingle almost 3 years ago

Fix logging for L2TP and PPPoE server login/logout events. Fixes #8164

See https://redmine.pfsense.org/issues/8164 for the reasoning about why it was done this way.

(cherry picked from commit 902a31e3fd419e2fc360ad891ee3a82209264e1a)

History

#1 Updated by Jim Pingle almost 3 years ago

  • Assignee set to Jim Pingle

#2 Updated by Jim Pingle almost 3 years ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Jim Pingle almost 3 years ago

  • Status changed from Feedback to Resolved
  • Target version changed from 2.4.3 to 2.4.2-p1

Also available in: Atom PDF