Project

General

Profile

Actions
Copy link

Bug #8220

closed
DF JP

UI does not allow multiple MAC for same DHCP address

Bug #8220: UI does not allow multiple MAC for same DHCP address

Added by Doug Fultz over 8 years ago. Updated over 8 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
DHCP (IPv4)
Target version:
2.4.3
Start date:
12/16/2017
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.2_1
Affected Architecture:
amd64

Description

The UI does not allow multiple MAC addresses to be assigned the same DHCP address, even when using different hostnames. Several forum posts and a previously closed issue, this should be allowed given that a different hostname is used.

https://forum.pfsense.org/index.php?topic=53418.0
https://forum.pfsense.org/index.php/topic,36066.msg186013.html#msg186013
https://redmine.pfsense.org/issues/1682

Unfortunately, it appears that the UI is blocking this.
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/services_dhcp_edit.php#L193-L199

Files

Screenshot from 2018-02-14 15-33-30.png (17.5 KB) Screenshot from 2018-02-14 15-33-30.png Paighton Bisconer, 02/14/2018 05:34 PM

Updated by Anonymous over 8 years ago Actions
Copy link
 #1

  • Assignee set to Jim Pingle

JP Updated by Jim Pingle over 8 years ago Actions
Copy link
 #2

As the discussion in some of those former tickets and posts implied, the IP address can be reused as well as the hostname. I removed both uniqueness checks from the page and the configuration appears to function properly.

Needs some more testing/confirmation but it looks OK here.

JP Updated by Jim Pingle over 8 years ago Actions
Copy link
 #3

Also: This problem was introduced over 4 years ago when a contributor added the IP address check instead of removing "IP" from the input error text in commit:ce13cc5f8f661f4ef0d24e237a83d4caccea6a11

JP Updated by Jim Pingle over 8 years ago Actions
Copy link
 #4

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:b2605914777a8026910bf8ce8b324fce61803ad2.

PB Updated by Paighton Bisconer over 8 years ago Actions
Copy link
 #5

Confirmed working on Current Base System 2.4.3.a.20180213.0339 built on Tue Feb 13 03:39:40 CST 2018

JP Updated by Jim Pingle over 8 years ago Actions
Copy link
 #6

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom