Project

General

Profile

Bug #8220

UI does not allow multiple MAC for same DHCP address

Added by Doug Fultz 10 months ago. Updated 8 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
DHCP Server
Target version:
Start date:
12/16/2017
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.2_1
Affected Architecture:
amd64

Description

The UI does not allow multiple MAC addresses to be assigned the same DHCP address, even when using different hostnames. Several forum posts and a previously closed issue, this should be allowed given that a different hostname is used.

https://forum.pfsense.org/index.php?topic=53418.0
https://forum.pfsense.org/index.php/topic,36066.msg186013.html#msg186013
https://redmine.pfsense.org/issues/1682

Unfortunately, it appears that the UI is blocking this.
https://github.com/pfsense/pfsense/blob/master/src/usr/local/www/services_dhcp_edit.php#L193-L199

Associated revisions

Revision b2605914 (diff)
Added by Jim Pingle 8 months ago

Do not apply a DHCP static mapping uniqueness test for hostnames or IP addresses. The DHCP daemon allows the entries to be duplicated provided they have unique MAC addresses or identifiers. Fixes #8220

History

#1 Updated by Steve Beaver 9 months ago

  • Assignee set to Jim Pingle

#2 Updated by Jim Pingle 8 months ago

As the discussion in some of those former tickets and posts implied, the IP address can be reused as well as the hostname. I removed both uniqueness checks from the page and the configuration appears to function properly.

Needs some more testing/confirmation but it looks OK here.

#3 Updated by Jim Pingle 8 months ago

Also: This problem was introduced over 4 years ago when a contributor added the IP address check instead of removing "IP" from the input error text in ce13cc5f8f661f4ef0d24e237a83d4caccea6a11

#4 Updated by Jim Pingle 8 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#5 Updated by Paighton B 8 months ago

Confirmed working on Current Base System 2.4.3.a.20180213.0339 built on Tue Feb 13 03:39:40 CST 2018

#6 Updated by Jim Pingle 8 months ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF