Bug #8502
open
main (top) menu items do not drop down in some cases
0%
Description
During testing php7 found main (top) menu items do not drop down on final pages of some pkgs, e.g. arpping, mtr. These pkgs do not have a problem themselves, stat page, processing and result page are well, this is only web-gui menu issue.
Stephen Beaver confirmed this is not php7 related issue.
Updated by Anonymous over 6 years ago
- Status changed from New to Feedback
Almost any PHP error anywhere in the system will break the menu system. This issue should be resolved when the last of the PHP7 issues have been resolved.
Updated by Jim Pingle over 6 years ago
- Status changed from Feedback to Confirmed
Some packages, including arping, mtr, nmap, and iperf, all behave this way. They use XML pages but when the user clicks the submit button they have a custom <custom_add_php_command> which runs the command, dumps the output, and then calls exit. The abrupt end makes sure the "settings" are not saved since they are not supposed to be persistent, but it also appears to cause the JS for the menus to fail, and presumably some other issues that have not yet been noticed.
This isn't new behavior though, it's been this way for years and isn't related to PHP 7.x changes. The nmap package even includes a JS button to go back to the nmap page so the user has a way to navigate back.
There is probably a much better way to handle the requirements of these packages rather than the kludge they use now.
Since this is not a regression this can be kicked forward to future versions as needed.
Updated by Anonymous over 6 years ago
- Target version changed from 2.4.4 to Future
Updated by Jim Pingle over 6 years ago
Also affects the Apple IPsec Profile generator. See #8709
Updated by Chris Macmahon over 6 years ago
ran arpping package 1.2.2_1, executed ping to mac, hover menu's don't populate, no crash recorded
ran package iperf (client) 2.0.5.5_3, to host package ran displayed results, hover menus didn't populate, no crash reported
ran package iperf (server) 2.0.5.5_3, client connected package ran displayed results, hover menus didn't populate, no crash reported
ran package mtr-nox 0.85.6_1, ran mtr to host, after complete hover menu's didn't populate, no crash reported
ran package nmap 1.4.4_1, scanned host, results displayed hover menu's didn't populate, no crash reported
Updated by Jim Pingle over 4 years ago
FYI- This no longer affects the IPsec Profile Wizard package as of v 1.0, since it has been changed to use a traditional GUI page and not the method which resulted in this behavior.