Bug #8515: ts wizard syntax error (as of 2.4.4.a.20180514.0905) - pfSense - pfSense bugtracker

Actions

Copy link

Bug #8515

closed

ts wizard syntax error (as of 2.4.4.a.20180514.0905)

Added by ROB VANHOOREN over 6 years ago. Updated over 6 years ago.

Status:

Resolved

Priority:

High

Assignee:

Category:

Traffic Shaper (ALTQ)

Target version:

2.4.4

Start date:

05/14/2018

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

Release Notes:

Affected Version:

2.4.4

Affected Architecture:

Description

gui> fw> shaper> wizard> dedicated>

result?

Parse error: syntax error, unexpected 'else' (T_ELSE) in /usr/local/www/wizards/traffic_shaper_wizard_dedicated.inc on line 781

thanks,
R.

Files

Download all files

floating-rules.png (63 KB) floating-rules.png	Floating rules	Anonymous, 05/19/2018 02:11 PM
Reload-status.log (2.55 KB) Reload-status.log	Reload status - after completing the wizard	Anonymous, 05/19/2018 02:12 PM

Actions

Copy link

Updated by Anonymous over 6 years ago

Status changed from New to Feedback

Fixed in next snapshot. Thanks!

Actions

Copy link

Updated by Anonymous over 6 years ago

% Done changed from 0 to 100

Applied in changeset 962c8cce48bc503301857037f0533d7a3b81f31d.

Actions

Copy link

Updated by ROB VANHOOREN over 6 years ago

whoops, that broke something else.

wizard> (steps) -> apply ... makes the floating rules but does not create any queues.

[15-May-2018 16:08:50 America/Toronto] PHP Warning: Invalid argument supplied for foreach() in /usr/local/www/wizards/traffic_shaper_wizard_dedicated.inc on line 1555

Actions

Copy link

Updated by Anonymous over 6 years ago

File floating-rules.png floating-rules.png added
File Reload-status.log Reload-status.log added

No "PHP Warning: Invalid argument supplied for foreach() in /usr/local/www/wizards/traffic_shaper_wizard_dedicated.inc on line 1555" error on 2.4.4.a.20180518.1741 CE sync'd to master, but when the wizard completes, it leaves shapers in the config.xml but there are no queues at Status > Queues, although the floating rules and queues seem to have been created successfully.

Actions

Copy link

Updated by Anonymous over 6 years ago

Retested Traffic Shaping Wizards on 2.4.4.a.20180609.0944 and got the following alerts in the GUI

Filter Reload

There were error(s) loading the rules: /tmp/rules.debug:40: errors in queue definition - The line in question reads [40]: queue qLink on igb1 priority 2 qlimit 500 priq ( ecn , default )
     2018-06-09 20:26:33
    There were error(s) loading the rules: /tmp/rules.debug:40: errors in queue definition - The line in question reads [40]: queue qLink on igb1 priority 2 qlimit 500 priq ( ecn , default )
     2018-06-09 20:27:24

Plus no queues under Status > Queues, although it did seem to create the floating firewall rule and put traffic shaping in the config.

Actions

Copy link