Project

General

Profile

Actions
Copy link

Bug #8636

closed

pfSense_kill_states function does not parse protocol parameter correctly

Added by Steven Brown almost 6 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
Rules / NAT
Target version:
-
Start date:
07/11/2018
Due date:
% Done:

0%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
All
Affected Architecture:
All

Description

Inside pfSense-ports/devel/php56-pfSense-module/files/pfSense.c the function pfSense_kill_states takes a parameter for network protocol.

When parsing the protocol string, it incorrectly compares the parameter when it should be testing for "udp", "icmpv6" and "icmp". This means it is impossible to kill "udp", "icmpv6" and "icmp" states based on protocol.

Attached is a patch to fix the issue.

Files

pfSense.c.patch (681 Bytes) pfSense.c.patch Steven Brown, 07/11/2018 12:59 AM
Actions
Copy link
 #1

Updated by Jim Pingle almost 6 years ago

  • Category set to Rules / NAT
  • Affected Version set to All
  • Affected Architecture All added
  • Affected Architecture deleted ()

Can you submit that as a Github pull request on the pfSense FreeBSD-ports repository at https://github.com/pfsense/freebsd-ports/ ?

This file specifically is:

https://github.com/pfsense/FreeBSD-ports/blob/devel/devel/php-pfSense-module/files/pfSense.c

It is much easier for us to review and merge patches submitted in that way. See https://www.netgate.com/docs/pfsense/development/submitting-a-pull-request-via-github.html

Actions
Copy link
 #3

Updated by Jim Pingle over 4 years ago

  • Status changed from New to Resolved

PR was merged several months ago.

Actions
Copy link

Also available in: Atom PDF