Project

General

Profile

Actions

Bug #9083

closed

Config upgrade issue with empty IPsec P1

Added by Jim Pingle about 3 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Upgrade
Target version:
Start date:
10/31/2018
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.4
Affected Architecture:
All

Description

An older configuration will fail to upgrade with an incomplete or empty IPsec Phase 1 section:

    <ipsec>
        <phase1></phase1>
        <logging>
            [...]
        </logging>
    </ipsec>

This generates a PHP error during the upgrade process, which then fails:

Fatal error: Uncaught Error: Cannot use string offset as an array in /etc/inc/upgrade_config.inc:5502
Stack trace:
#0 /etc/inc/config.lib.inc(378): upgrade_174_to_175()
#1 /etc/rc.bootup(125): convert_config()
#2 {main}
  thrown in /etc/inc/upgrade_config.inc on line 5502

Actions #1

Updated by Jim Pingle about 3 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100
Actions #2

Updated by Vladimir Lind about 3 years ago

On 2.4.5-DEVELOPMENT (amd64) built on Wed Oct 03 17:24:18 EDT 2018 edited config.xml - cut out content between <phase1></phase1> of existing ipsec p1 instance, saved changes. Then run rm /tmp/config.cache. After that started upgrade to latest snap. Upgrade to "Wed Nov 14 23:01:04 EST 2018" finished successfully.

Actions #3

Updated by Anonymous about 3 years ago

  • Status changed from Feedback to Resolved

Tested on 2.4.4, was able to reproduce the bad behavior. Tested on 2.4.5.a.20181116.1325 and the behavior could not be reproduced, looks good.

Actions

Also available in: Atom PDF