Bug #9170: PHP error in Setup Wizard when gateways have been deleted - pfSense - pfSense bugtracker

Actions

Copy link

Bug #9170

closed

PHP error in Setup Wizard when gateways have been deleted

Added by Jim Pingle almost 6 years ago. Updated almost 6 years ago.

Status:

Resolved

Priority:

Normal

Assignee:

Jim Pingle

Category:

Web Interface

Target version:

2.4.4-p2

Start date:

12/05/2018

Due date:

% Done:

100%

Estimated time:

Plus Target Version:

Release Notes:

Affected Version:

2.4.4_1

Affected Architecture:

All

Description

If a gateway existed but was deleted, the config can be left with <gateways></gateways> which leads to a PHP error in the setup wizard:

PHP Fatal error:  Uncaught Error: Cannot iterate on string offsets by reference in /usr/local/www/wizard.php(1017) : eval()'d code:8
Stack trace:
#0 /usr/local/www/wizard.php(1017): eval()
#1 {main}
  thrown in /usr/local/www/wizard.php(1017) : eval()'d code on line 8

This is ultimately from source:src/usr/local/www/wizards/setup_wizard.xml#L772 trying to iterate the gateways array that isn't properly set as an array in this specific case.

Actions

Copy link

Updated by Jim Pingle almost 6 years ago

Description updated (diff)

Actions

Copy link

Updated by Jim Pingle almost 6 years ago

Note: This also only affects the wizard when setting a static WAN and upstream gateway.

Fix pushed, will show up momentarily.

Actions

Copy link

Updated by Jim Pingle almost 6 years ago

Status changed from New to Feedback
% Done changed from 0 to 100

Applied in changeset f5f79fcc24241f0a76f6a7fe9b32917bee64e393.

Actions

Copy link

Updated by Constantine Kormashev almost 6 years ago

I checked the issue on latest 2.4.5-DEV and did not observe it. Gateways and their routes were successfully deleted and Wizard did not produce any errors.

Actions

Copy link