Project

General

Profile

Actions

Bug #9193

closed

firewall_nat.php: PHP error deleting an imported NAT rule with no firewall rules present

Added by Jim Pingle almost 3 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Rules / NAT
Target version:
Start date:
12/12/2018
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.4_1
Affected Architecture:
All

Description

Scenario:
1. Empty firewall rule list <filter></filter>
2. Imported NAT rules that reference associated filter rules that do not exist because of point 1

Attempting to delete an affected NAT rule will trigger a PHP error:

Fatal error: Uncaught Error: Only variables can be passed by reference in /usr/local/www/firewall_nat.php:104 Stack trace: #0 {main} thrown in /usr/local/www/firewall_nat.php on line 104 PHP ERROR: Type: 1, File: /usr/local/www/firewall_nat.php, Line: 104, Message: Uncaught Error: Only variables can be passed by reference in /usr/local/www/firewall_nat.php:104 Stack trace: #0 {main} thrown

Actions #1

Updated by Jim Pingle almost 3 years ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100
Actions #2

Updated by Vladimir Lind almost 3 years ago

On 2.4.5-dev 20 Nov:

Repeated steps 1 and 2 in bug description - after that triggered PHP error by NAT rule deletion attempt.

On 2.4.5-DEVELOPMENT (amd64) built on Thu Jan 03 15:25:56 EST 2019:

Repeated steps 1 and 2 in bug description - NAT rule with accossiated firewall rule was successfully deleted.
Looks good.

Actions #3

Updated by Jim Pingle almost 3 years ago

  • Status changed from Feedback to Resolved
Actions #4

Updated by Jim Pingle over 2 years ago

  • Target version changed from 48 to 2.5.0
Actions #5

Updated by Jim Pingle over 2 years ago

  • Target version changed from 2.5.0 to 2.4.4-p3
Actions #6

Updated by Jim Pingle over 2 years ago

  • Status changed from Resolved to Feedback
Actions #7

Updated by Constantine Kormashev over 2 years ago

Tried on 2.4.4-p3, I do not observe the issue. I could upload config with empty firewall rule list <filter></filter>, NAT/PortForward entries and deleting NAT entries did not lead to any issue.

Actions #8

Updated by Jim Pingle over 2 years ago

  • Status changed from Feedback to Resolved
Actions

Also available in: Atom PDF