Project

General

Profile

Actions
Copy link

Bug #9193

closed
JP JP

firewall_nat.php: PHP error deleting an imported NAT rule with no firewall rules present

Bug #9193: firewall_nat.php: PHP error deleting an imported NAT rule with no firewall rules present

Added by Jim Pingle almost 8 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Jim Pingle
Category:
Rules / NAT
Target version:
2.4.4-p3
Start date:
12/12/2018
Due date:
% Done:

100%

Estimated time:
Plus Target Version:
Release Notes:
Affected Version:
2.4.4_1
Affected Architecture:
All

Description

Scenario:
1. Empty firewall rule list <filter></filter>
2. Imported NAT rules that reference associated filter rules that do not exist because of point 1

Attempting to delete an affected NAT rule will trigger a PHP error:

Fatal error: Uncaught Error: Only variables can be passed by reference in /usr/local/www/firewall_nat.php:104 Stack trace: #0 {main} thrown in /usr/local/www/firewall_nat.php on line 104 PHP ERROR: Type: 1, File: /usr/local/www/firewall_nat.php, Line: 104, Message: Uncaught Error: Only variables can be passed by reference in /usr/local/www/firewall_nat.php:104 Stack trace: #0 {main} thrown

JP Updated by Jim Pingle almost 8 years ago Actions
Copy link
 #1

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 100

Applied in changeset commit:701728c0778cbb4ccf95ebfad30bf56339d1a7e3.

VL Updated by Vladimir Lind over 7 years ago Actions
Copy link
 #2

On 2.4.5-dev 20 Nov:

Repeated steps 1 and 2 in bug description - after that triggered PHP error by NAT rule deletion attempt.

On 2.4.5-DEVELOPMENT (amd64) built on Thu Jan 03 15:25:56 EST 2019:

Repeated steps 1 and 2 in bug description - NAT rule with accossiated firewall rule was successfully deleted.
Looks good.

JP Updated by Jim Pingle over 7 years ago Actions
Copy link
 #3

  • Status changed from Feedback to Resolved

JP Updated by Jim Pingle over 7 years ago Actions
Copy link
 #4

  • Target version changed from 48 to 2.5.0

JP Updated by Jim Pingle over 7 years ago Actions
Copy link
 #5

  • Target version changed from 2.5.0 to 2.4.4-p3

JP Updated by Jim Pingle over 7 years ago Actions
Copy link
 #6

  • Status changed from Resolved to Feedback

CK Updated by Constantine Kormashev over 7 years ago Actions
Copy link
 #7

Tried on 2.4.4-p3, I do not observe the issue. I could upload config with empty firewall rule list <filter></filter>, NAT/PortForward entries and deleting NAT entries did not lead to any issue.

JP Updated by Jim Pingle over 7 years ago Actions
Copy link
 #8

  • Status changed from Feedback to Resolved
Actions
Copy link

Also available in: Atom