Project

General

Profile

Bug #9508

Potential XSS in services_acb.php via download parameter

Added by Jim Pingle 5 months ago. Updated 5 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Backup / Restore
Target version:
Start date:
05/09/2019
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:
All

Description

Attempt to load /services_acb.php?download=%22%3E%3Cscript%3Ealert(1)%3C/script%3E and the client displays a JS alert.

The download parameter it being put into a URL for the Revision tab without encoding at source:src/usr/local/www/services_acb.php#L374

Associated revisions

Revision ce77c104 (diff)
Added by Jim Pingle 5 months ago

Encode download parameter before use. Fixes #9508

Revision 48ab49ab (diff)
Added by Jim Pingle 5 months ago

Encode download parameter before use. Fixes #9508

(cherry picked from commit ce77c104eee92cfbbc0d84980e60899295dadeac)

History

#1 Updated by Jim Pingle 5 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#2 Updated by Jim Pingle 5 months ago

  • Parent task set to #9398

#3 Updated by Jim Pingle 5 months ago

  • Target version changed from 2.5.0 to 2.4.4-p3

#4 Updated by Jim Pingle 5 months ago

  • Parent task changed from #9398 to #9515

#5 Updated by Jim Pingle 5 months ago

  • Status changed from Feedback to Resolved

Unable to reproduce on -p3. Looks good.

#6 Updated by Jim Pingle 5 months ago

  • Private changed from Yes to No

Also available in: Atom PDF