Project

General

Profile

Bug #9736

status.php: Sanitize oinkcode and etprocode of snort/surricata

Added by Viktor Gurov 10 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Web Interface
Target version:
Start date:
09/09/2019
Due date:
% Done:

100%

Estimated time:
Affected Version:
All
Affected Architecture:

Description

config-sanitized.xml keep <oincmastercode> and <etpro_code> of snort package
and <oinkcode> and <etprocode> of suricata package
these codes used for paid subscriptions and must be sanitized from config-sanitized.xml

2.5.0-DEVELOPMENT (amd64)
built on Sun Sep 08 23:28:16 EDT 2019
FreeBSD 12.0-RELEASE-p10

Associated revisions

Revision 9adb7806 (diff)
Added by Jim Pingle 9 months ago

Fix oinkmastercode tag in status.php. Fixes #9736

Revision a8449a68 (diff)
Added by Jim Pingle 9 months ago

Fix oinkmastercode tag in status.php. Fixes #9736

(cherry picked from commit 9adb7806cffdd1393fd9223c17d7a938a37944c4)

History

#1 Updated by Jim Pingle 10 months ago

  • Assignee set to Jim Pingle

#2 Updated by Jim Pingle 10 months ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

#3 Updated by Viktor Gurov 9 months ago

Jim Pingle wrote:

Fixed in 17640476a57a41415fec579c40faebbfeff0022d

<snortglobal>
...
<oinkmastercode>954aa4a5b38595eac4b4271564bf9f63cc9c7d0f</oinkmastercode>
                        <etpro_code>xxxxx</etpro_code>
...
</snortglobal>

<oincmastercode> of snort is not sanitized

suricata is ok:
<oinkcode>xxxxx</oinkcode>
<etprocode>xxxxx</etprocode>

#4 Updated by Jim Pingle 9 months ago

  • Status changed from Feedback to In Progress

#5 Updated by Jim Pingle 9 months ago

  • Status changed from In Progress to Feedback

#6 Updated by Viktor Gurov 9 months ago

Jim Pingle wrote:

Applied in changeset 9adb7806cffdd1393fd9223c17d7a938a37944c4.

<oinkmastercode>xxxxx</oinkmastercode>

ok now

Resolved

#7 Updated by Jim Pingle 9 months ago

  • Status changed from Feedback to Resolved

#8 Updated by Jim Pingle 8 months ago

  • Private changed from Yes to No

#9 Updated by Jim Pingle 7 months ago

  • Target version changed from 2.5.0 to 2.4.5

#10 Updated by Jim Pingle 7 months ago

  • Status changed from Resolved to Feedback

Needs checked and/or tested again on 2.4.5 snapshots

#11 Updated by Anonymous 7 months ago

  • Status changed from Feedback to Resolved

Tested on 2.4.5.a.20191209.0732, works as expected.

Also available in: Atom PDF