Project

General

Profile

Bug #9760

FRR: "Log Adjacency Changes" Option in "OSPF Settings" not working.

Added by Bruno Solal about 1 month ago. Updated about 1 month ago.

Status:
Resolved
Priority:
Normal
Assignee:
Category:
FRR
Target version:
-
Start date:
09/13/2019
Due date:
% Done:

100%

Estimated time:
Affected Version:
2.4.4-p3
Affected Architecture:
All

Description

When the option "Log Adjacency Changes" is selected in the GUI in "OSPF Settings" tab, no changes are made in frr config. (I checked with vtysh / show running-config).
Normally, this option should add "log-adjacency-changes detail" in the config.

In the file frr_ospf.inc, I found this:
if ($ospfd_conf['logging'] && $ospfd_conf['adjacencylog']) {
$conffile .= " log-adjacency-changes detail\n";
}

I don't know exactly, but it seems to me we should have something like:
if ($frr_conf['logging'] && $ospfd_conf['adjacencylog']) {
$conffile .= " log-adjacency-changes detail\n";
}

Could you please take a look at this?

History

#1 Updated by Jim Pingle about 1 month ago

  • Status changed from New to Feedback
  • % Done changed from 0 to 100

You are correct, that test was wrong. I pushed a fix. Thanks!

#2 Updated by Bruno Solal about 1 month ago

I tested the fix and it works well.
Thank you very much!

#3 Updated by Jim Pingle about 1 month ago

  • Status changed from Feedback to Resolved

Also available in: Atom PDF