Complete conversion; add <form>, remove dead sntxhgh, use events
refs #94
Merge pull request #94 from sbeaver-netgate/edit_file
Convert edit.php
correct nesting & whitespace, then run away from this page fast
also no need for popen, you can simply use system() instead
refs #92
Merge pull request #92 from sbeaver-netgate/exec
Convert exec.php
Completed diag_routes, add panels, fix generated tables
refs #91
Merge branch 'diag_routes' of https://github.com/sbeaver-netgate/pfsense into sbeaver-netgate-diag_routes
Completed diag_ndp, made consistent with status_dhcp_leases
refs #85
Merge pull request #85 from sbeaver-netgate/diag_ndp
Convert diag_ndp.php
Completed diag_limiter_info.php; made consistent with other pages
refs #83
Merge pull request #83 from sbeaver-netgate/diag_limiter_info
Convert diag_limiter_info.php
Reorder elements, use events, remove table
refs #79
Merge pull request #79 from sbeaver-netgate/diag_system_activity
Converted diag_system_activity
Completed conversion of diag_pf_info - introduce Form
Merge pull request #77 from sbeaver-netgate/diag_pf_info
Converted diag_pf_info.php
complete conversion of diag_system_pftop.php
refs #70
make construct less strict to allow hiding submit button
Merge pull request #70 from sbeaver-netgate/diag_system_pftop
Converted diag_system_pftop
Revised per SvL comments
Thank you.
- Remove htmlspecialchars; Form_Element->__toString() already encodes attribute values- Use password input type for password
Refs. #81
Merge pull request #81 from sbeaver-netgate/diag_authentication
Conversion of diag_authentication completed
Some more rigorous rewrite of diag_states_summary
- Replace table in table with table cells spanning two or more rows- Removed redundant panel- Removed column width classes from table cells; they're not intended for this usage
Refs. #78
Merge pull request #78 from sbeaver-netgate/diag_states_summary
Diag states summary
Tweak converted halt.php
- Replace 'submit' with 'save', which is more in line with the Form.class- Add h2 panel title- Just match string instead of stristr of gettext result
Refs. #75
Table replaced with panel
Thank you for your suggestion. I will revisit other pages that usetables and make the same change.
Merge pull request #75 from sbeaver-netgate/halt
Merge updated halt.php
edit.php - Fixed tester class
edit.php - Form field class corrected
edit.php conversion complete
This was a tricky conversion because of the included JS libraries andthe in-line JS functions.Syntax highlighting has been eliminated (because it had never workedand is not needed).
The files:filebrowser/*javascript/base64.js...
exec.php conversion complete
Tables eliminated, panels added, panels re-ordered to place output nearthe control that generated it. Messages converted to alerts.
Reverted change - Wrong branch :(
diag_exec.php conversion complete
Page re-factored to display output in panels and to put thewarnings/messages alongside the control that generated them.
dig_routes Update complete
Javascript required update for bootstrap compatibility.Form.class.php updated so that form button is not drawn if the buttonname is empty.
2 minor typos
use proper variable to detect state
refs #69
Properly convert select > radios
correct several typos, remove whitespace from pre
Fix panel structure.
- Contents should be placed in a `.panel-body`, which adds proper padding.- Title is wrapped in a H2, which is usually semantically correct when starting a new panel
Refs. #69
Updated per SH
Mostly :)
Update completed
Completed
Ready for review
Conversion completed
Changes checkbox layout
Added braces for clarity around if(run)
Converted
Added some Ajax to allow the user to freeze the page (otherwise it isnot possible to view it before it refreshes)
Eliminate white space in Submit value
Updated
Updated to bootstrap
Use of Ajax in this file precluded the use of Form.classes
Table was replaced with bootstrap panel/row and input component classesupdated.
Fixed tabs
Mostly by adding BS-3 classes to the existing tables, but also byadding a nested table to display the states.
Remove nested tables
final changes
Changes are mostly to table specifications and replacing spaces inoriginal file with tabs.
Converted system_gateways and system_gateways_edit
Input - for type=number, default to min=1 & step=1
Group - add support for $params in setHelp
Group - only push placeholder if Input doesn't have it yet
Input - introduce hasAttribute method
refs #56
diag_dns - TIL HTML, let's not barf out incomplete nodes
removing unused maintable.inc
Converted status_dhcpv6_leases, 2 minor tweaks in status_dhcp_leases
Converted status_dhcp_leases.php
Merge branch 'master' into bootstrap
Merge branch 'master' of github.com:pfsense/pfsense
Convert fw_alias_import, 2 minor bugfixes in other files
fixes #44
Bugfix; textarea needs form-control class too
Convert firewall_aliases_* to bootstrap, pending _import
refs #44
Inputs hidden by bindCollapseToOptions should be disabled
fixes #57
Initial enableDuplication javascript implementation, pending layout
refs #45
Introduce Group::enableDuplication and Input::setIsRepeated
also fix label-target, was based on name but should be ID instead. Alsomake ID unique to facilitate functionality
Multiple Inputs in group = copy Title to placeholder
fixes #56
shouldn't need this as its own inc anymore, but only changing in master since 2_2 nearing release
There is no longer any need to restrict protocols for IPv4+IPv6 rules, the appropriate ruleset is generated and problem scenarios that would otherwise break here are prevented by other input validation.
remove dead code, clean up excess white space a bit.
Fixes #4504 use correct key index
Fixes #4504 Allow the bypass policy for LAN to be enabled and prevent traffic sent to lan ip to go to the ipsec tunnel
Fixes #4259 Use proper variable to do calculations
Add hidden input in a proper way
Refs. #22
Emulate existing logic
“More information” and “timing” sections should display only after alookup is attempted.
Removed unused hidden form.
Merge branch 'sbeaver-netgate-diag_dns' into bootstrap
- refactored Form_Table to plain html- put results below form- reverted a few unintentional changes
Merge branch 'diag_dns' of git://github.com/sbeaver-netgate/pfsense into sbeaver-netgate-diag_dns
IpAddress - make range go down instead of up
Input - better chaining plus added setPattern, IpAddress - chaining fix
Combo changes to support diag_dns.php
Version allows button to be suppressed
Converted to bootstrap
HTML largely replaced by SH framework
Add a table to a section by passing it a two-dimensional array
Is there a better way to do this? Can the table position be controlled?
Allow "Save" button to be suppressed
new Form(false) suppresses the “Save” button so that you can then addyour won custom button.
Add SCTP to protocol list for filtering.
Fix IPsec Advanced Settings uniqueids. It was neither set in strongswan config, nor picked up correctly in the UI.
Fix encoding issues in Configuration History list.
Fix a few misc encoding issues in load balancer code.
- Consistent table styles (table table-striped table-hover)- Wrap tables in table-responsive (excluding widgets)
Refs. #51
- Consistent table styles (table table-striped table-hover)- Wrap tables in table-responsive- Wrap action buttons in nav.action-buttons- Removed unnecessary form from vpn_l2tp_users.php
Tweak vpn_ipsec_keys layout
- Better name for 'edit user' button- Wrap action buttons- Sprinkle some clears in CSS for table container and forms (self-clearing with overflow:hidden)
Convert vpn_ipsec_keys_edit to bootstrap
Convert to bootstrap
Fix todo, let checkbox toggle maxmss input
Add debug settings as separate group
Updated & moved PROGRESS doc, fixes icons
replace Input->column methods with generic Element plus fixes
Form.class - fix adding offset to submit buttonCheckbox - add class to column, not input. Fix displayAsRadio returnElement - no longer abstract, used as a generic element in Input
fixes #43, refs #37