Project

General

Profile

« Previous | Next » 

Revision 1c367372

Added by PiBa-NL about 7 years ago

ipsec, fix Phase1 and Phase2 edit pages 'section' class does not have a setHelp() function, and add help for insecure DH groups on mobile settings page

View differences:

src/usr/local/www/vpn_ipsec_mobile.php
676 676
	'Group',
677 677
	$pconfig['pfs_group'],
678 678
	$p2_pfskeygroups
679
))->setWidth(2);
679
))->setHelp('Note: Groups 1, 2, 22, 23, and 24 provide weak security and should be avoided.');
680 680

  
681 681
$section->add($group);
682 682

  
src/usr/local/www/vpn_ipsec_phase1.php
854 854
	$section->add($group);
855 855
	$counter += 1;
856 856
}
857
$section->setHelp('Note: Blowfish, 3DES, CAST128, MD5, SHA1, and DH groups 1, 2, 22, 23, and 24 provide weak security and should be avoided.');
857
$section->addInput(new Form_StaticText('', ''))->setHelp('Note: Blowfish, 3DES, CAST128, MD5, SHA1, and DH groups 1, 2, 22, 23, and 24 provide weak security and should be avoided.');
858 858
$form->add($section);
859 859

  
860 860
$btnaddopt = new Form_Button(
src/usr/local/www/vpn_ipsec_phase2.php
665 665
$section->add($group);
666 666

  
667 667
$sm = (!isset($pconfig['mobile']) || !isset($a_client['pfs_group']));
668
$helpstr = $sm ? '':'Set globally in mobile client options. ';
669
$helpstr .= 'Note: Groups 1, 2, 22, 23, and 24 provide weak security and should be avoided.';
668 670

  
669 671
$section->addInput(new Form_Select(
670 672
	'pfsgroup',
671 673
	'PFS key group',
672 674
	$pconfig['pfsgroup'],
673 675
	$sm ? $p2_pfskeygroups:array()
674
));
675

  
676
$helpstr = $sm ? '':'Set globally in mobile client options. ';
677
$helpstr .= 'Note: Groups 1, 2, 22, 23, and 24 provide weak security and should be avoided.';
678
$section->setHelp($helpstr);
676
))->setHelp($helpstr);
679 677

  
680 678
$section->addInput(new Form_Input(
681 679
	'lifetime',

Also available in: Unified diff