pfSense

Automatic panel collapse defines moved to jquery/pfSenseHelpsers.js
define(COLLAPSIBLE, 0x08);
define(SEC_CLOSED, 0x04);
define(SEC_OPEN, 0x00);

Merge pull request #2217 from NOYB/HTML_Compliance_-_Collapsible_Form_Section_HREF

Merge pull request #2216 from NOYB/HTML_Compliance_-_Checkbox_Display_As_Radio_Unique_ID

HTML Compliance - Collapsible Form Section HREF

Bad value for attribute href on element a: Illegal character in fragment: not a URL code point.

<a data-toggle="collapse" href="#<id> .panel-body">
Syntax of URL:Any URL. For example: /hello, #canvas, or http://example.org/. Characters should be represented in NFC and spaces should be escaped as %20....

HTML Compliance - Checkbox Display As Radio Unique ID

Ensure checkbox display as raido has unique id.
Allow an id to be passed in displayAsRadio() as argument⁰.
If no argument is passed, construct id as name_value:uniqid.

Previous behavior was id = name. So all the radio buttons of the set had same id.

HTML Compliance - Form Action Attribute

Fix Empty Form Action Attribute Violation

An empty form action attribute is an HTML4 and HTML5 specification violation.

http://www.w3.org/TR/html5/forms.html#attr-fs-action
"The action and formaction content attributes, if specified, must have a value that is a valid non-empty URL potentially surrounded by spaces."...

Revise collapsible section behavior to use defines (COLLAPSIBLE, SEC_OPEN, SEC_CLOSED)

Spelling

Further changes to Section.class.php and to diag_logs_filter.php
Experimental section collapse

Form_Section() now accepts up to 4 arguments: Form_section(title, id, collapsable, initiall_collapsed)

collapsable = true specifies that the panel should be collapsable and should have a plus/minus icon in the title bar to allow that. Defaults to false...

Add full classpath to autoloader so that packages can run from their own directories.