pfSense

Simplify divert port generation and make sure it is even to leave room to ipfw-classifyd to always open 2 divert sockets one for reading and one for writing.

Remove brain dead comment by another brain washed comment.

- Should fix captive portal on carps Issue #116
- Should fix the captive portal not working reports and Issue #118
NOTE: Now Captive portal is open on dns so no more is needed to add dns servers to pass through ips.

Previous commit on carp was strange and breaking the distinction and usefulness of some functions.
Make sure that the behaviour returns to the previous architecture and to keep things right.

Carp needs some more work on handling the interface as all other interfaces, but that needs an upgrade path too....

Do not 'spam' a new ipfw-classifyd for each save. If we hit save for an existing configuration(did changes to existing one) just tell ipfw-classifyd to reload the config.

err, this defeats the entire purpose of NAT-T for clients behind the firewall, let's not do this.

Stop spamming the logs with config_unlock() is depricated please use unlock().

Don't add port on no nat rules. Fixes #120

Fix "Filter rule association" "Pass" option

Move newer xmlreader code to xmlreader.inc. Restore old xmlparse code to xmlparse.inc. Default to the older xmlparse.inc but add a flag check if /cf/conf/use_xmlreader is present the newer code will be included instead until the remaining bugs can be resolved with it (see rcs for many).