1) Remove a couple of unused calls to is_specialnet() 2) Change srctype_selected() to use a similar scheme to dsttype_selected() to decide if the existing value matches one of the dropdown list items. 3) Items like "WAN net" and "LAN net" in the src type dropdown were showing as just "WAN" and "LAN" in the dst type dropdown. Fixup the build_dsttype_list() code so it does the same as build_srctype_list() when making the text for those interface networks.
Related issues
Bug #6173: /firewall_nat_edit.php: dsttype_selected wrong when edited w/VIPs defined
Fix #6173 Refactor NAT Edit src type matching
1) Remove a couple of unused calls to is_specialnet()
2) Change srctype_selected() to use a similar scheme to dsttype_selected() to decide if the existing value matches one of the dropdown list items.
3) Items like "WAN net" and "LAN net" in the src type dropdown were showing as just "WAN" and "LAN" in the dst type dropdown. Fixup the build_dsttype_list() code so it does the same as build_srctype_list() when making the text for those interface networks.