Project

General

Profile

« Previous | Next » 

Revision 786ff5eb

Added by phildd over 12 years ago

Handle null parameter to services_dyndns_configure

When service_dyndns_configure is called with a null parameter, it should check/update the dyndns state of all interfaces configured for dyndns. But actually it is only updating gateway groups. e.g. the daily cron job /etc/rc.dyndns.update does not update an ordinary WAN interface.
This fixes the problem.

View differences:

etc/inc/services.inc
6 6

  
7 7
	originally part of m0n0wall (http://m0n0.ch/wall)
8 8
	Copyright (C) 2003-2004 Manuel Kasper <mk@neon1.net>.
9
	Copyright (C) 2010	Ermal Lui
9
	Copyright (C) 2010	Ermal Luci
10 10
	All rights reserved.
11 11

  
12 12
	Redistribution and use in source and binary forms, with or without
......
1493 1493
			echo gettext("Starting DynDNS clients...");
1494 1494

  
1495 1495
		foreach ($dyndnscfg as $dyndns) {
1496
			$failovergroup = interface_gateway_group_member($int);
1497
			if (!empty($int) && $int == $dyndns['interface']) {
1496
			if ((empty($int)) || ($int == $dyndns['interface']) || (is_array($gwgroups[$dyndns['interface']]))) {
1498 1497
				services_dyndns_configure_client($dyndns);
1499 1498
				sleep(1);
1500
			} elseif (is_array($gwgroups[$dyndns['interface']])){
1501
				services_dyndns_configure_client($dyndns);
1502
				sleep(1);				
1503
			} else {
1504
				continue;
1505 1499
			}
1506 1500
		}
1507 1501

  

Also available in: Unified diff